From: Philippe Waroquiers via Gdb-patches <gdb-patches@sourceware.org>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: remove unused parameters in print_doc_of_command, apropos_cmd
Date: Sun, 02 Apr 2023 13:43:32 +0200 [thread overview]
Message-ID: <eae9d77895412173d7b883375ab61f9d9188fe2b.camel@skynet.be> (raw)
In-Reply-To: <20230401193240.1619282-1-simon.marchi@polymtl.ca>
On Sat, 2023-04-01 at 15:32 -0400, Simon Marchi via Gdb-patches wrote:
> I noticed the prefix parameter was unused in print_doc_of_command. And
> when removing it, it becomes unused in apropos_cmd.
>
> Sending as non-obvious, in case somebody can spot if this is a mistake,
> and it should actually be used.
I think that the prefix arguments were removed as part of
2f822da535ba9b159174d02d7114b4fc4f7c8818
Likely these 2 prefix args felt through the cracks.
Philippe
next prev parent reply other threads:[~2023-04-02 11:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-01 19:32 Simon Marchi via Gdb-patches
2023-04-01 22:58 ` Kevin Buettner via Gdb-patches
2023-04-02 11:43 ` Philippe Waroquiers via Gdb-patches [this message]
2023-04-02 18:12 ` Simon Marchi via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eae9d77895412173d7b883375ab61f9d9188fe2b.camel@skynet.be \
--to=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox