From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id JCJhGZHfs2FJZwAAWB0awg (envelope-from ) for ; Fri, 10 Dec 2021 18:15:29 -0500 Received: by simark.ca (Postfix, from userid 112) id 576A01F0D0; Fri, 10 Dec 2021 18:15:29 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, NICE_REPLY_A,RDNS_DYNAMIC autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C63B51EDEE for ; Fri, 10 Dec 2021 18:15:28 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0696D3857C77 for ; Fri, 10 Dec 2021 23:15:28 +0000 (GMT) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by sourceware.org (Postfix) with ESMTPS id 892C3385801D for ; Fri, 10 Dec 2021 23:15:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 892C3385801D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f53.google.com with SMTP id o13so17363433wrs.12 for ; Fri, 10 Dec 2021 15:15:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=8+rlOpYaBs6p/MuF3lgQIRpDxBzuAvMvNqTczIDhwUA=; b=begirPOcmrfgRzmdKPm6RWgUhPvpjmQOoHB6G0IQmxPn23ffKXqIzHw2wbqaaYxOOD yrNU7COZRlYgjRb615ZW7JlvPqxR9k5FULsoHp7K0BgqrG7Z0dBOiAiXop5dg7B2m3Cb qFCGcILe58Y9uyGYy4hVXwQssgmFNuG4qCw52cni7/UuG2zf80oHPhBVrhDjSbQaARMD QUam8uxouOP902MoIFkGnm8rEchD24GCpd+ZliH+WgQ5DBP/yOlzP/Tr6181Wjj6AA+s q8LdKWJG/BO4BmQw1z0en9yohKVo+zBgEoZ9OC3U3D/Q8E6rcY0aLTS/W9QvJde7w06N ay0w== X-Gm-Message-State: AOAM532YpDzxcUFqw6RhxlKiSq0UHtWfBDuQylvOWg4WJUH0LRcC9bOg BTxiiMSL3LSt+qb9W2dIGL0PUCuY8go= X-Google-Smtp-Source: ABdhPJyIX+EvosNOlZ8BjkiHPCU+vvB0/C32XfHJI95xil5J3g+8zb+Q8JlTAyVXZptkocZSqgKb0w== X-Received: by 2002:adf:dd46:: with SMTP id u6mr17755047wrm.280.1639178115604; Fri, 10 Dec 2021 15:15:15 -0800 (PST) Received: from ?IPV6:2001:8a0:f912:1a00:d3db:ac91:4b9e:1449? ([2001:8a0:f912:1a00:d3db:ac91:4b9e:1449]) by smtp.gmail.com with ESMTPSA id n14sm4089625wrf.69.2021.12.10.15.15.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Dec 2021 15:15:14 -0800 (PST) Message-ID: Date: Fri, 10 Dec 2021 23:15:13 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH 19/29] gdb/testsuite: Remove duplicates from gdb.base/exprs.exp Content-Language: en-US To: Lancelot SIX , gdb-patches@sourceware.org References: <20211121175636.779325-1-lsix@lancelotsix.com> <20211121175636.779325-20-lsix@lancelotsix.com> From: Pedro Alves In-Reply-To: <20211121175636.779325-20-lsix@lancelotsix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-11-21 17:56, Lancelot SIX via Gdb-patches wrote: > When running the testsuite, I have: > > Running .../gdb/testsuite/gdb.base/exprs.exp ... > DUPLICATE: gdb.base/exprs.exp: \$[0-9]* = red (setup) > > Fix by using with_test_prefix where appropriate. > > Tested on x86_64-linux. > --- > gdb/testsuite/gdb.base/exprs.exp | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.base/exprs.exp b/gdb/testsuite/gdb.base/exprs.exp > index 50272d133a2..0525f76a44c 100644 > --- a/gdb/testsuite/gdb.base/exprs.exp > +++ b/gdb/testsuite/gdb.base/exprs.exp > @@ -238,7 +238,9 @@ test_expr "print \"x\" \"y\" \"z\"" "\\$\[0-9\]* = \"xyz\"" > # Enum formatting tests. > test_expr "print red" "\\$\[0-9\]* = red" > gdb_test "set output-radix 8" ".*" > -test_expr "print red" "\\$\[0-9\]* = red" > +with_test_prefix "with output-radix 8" { > + test_expr "print red" "\\$\[0-9\]* = red" > +} > test_expr "print/d red" "\\$\[0-9\]* = 0" The following test_expr is also under output-radix 8. This seems to be begging for: with_test_prefix "output-radix 8" { gdb_test "set output-radix 8" ".*" test_expr "print red" "\\$\[0-9\]* = red" test_expr "print/d red" "\\$\[0-9\]* = 0" gdb_test "set output-radix 10" ".*" } WDYT? > >