From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id B3JuHQs0Ympg6SkAWB0awg (envelope-from ) for ; Thu, 23 Jul 2026 11:32:27 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Eu2yeKbm; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 63E891E09E; Thu, 23 Jul 2026 11:32:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C3C161E099 for ; Thu, 23 Jul 2026 11:32:26 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 737D44BA2E32 for ; Thu, 23 Jul 2026 15:32:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 737D44BA2E32 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Eu2yeKbm Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 985484BA2E0B for ; Thu, 23 Jul 2026 15:31:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 985484BA2E0B Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 985484BA2E0B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784820719; cv=none; b=RrbaIxWUZ+QYhMB8xUZBNxO7ofkwVcynFBpcPWed/CT/xWggRpK09Ij0GW00XN0hwuU46GJWfybbQBVqiKgNS241qp1j7X1jlONi0BaTv0/3WBG8YI1efJdVRZjlae8UpuZv8smlFKcMgzB8OhyIa9v4OdJubnzuciddjB9SHe8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784820719; c=relaxed/simple; bh=UN3XN/zPdvTB96qwHUxfZhwuJ8l52gDSzlstBfMd3eQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=NMM7BoLEyW4xAr44p2Fz+wRrkRLhwAFDPe0bWWjkL0QuBjWTpcpnAMeUXOmPAtUl/yK+t7idR3ZZEXrB53r358eHoC6RCMSGTB5zoD0dHBixl/cSNiUrutC7KzG5W9tITxKU34HFtxuXjjuSMsFd27SvDz6TDVzWsCFiJU5KCDE= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Eu2yeKbm DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 985484BA2E0B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784820719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/XuKtYklbAMMLRpHcgZKJLkNu35do35tKSI65PP+qw0=; b=Eu2yeKbm3+nH3TPi6idCUR7WT7JhmhGPzslhrqnlvzPt13/ViE5VByfm1igd1q2steC+RY QjT/g5FoCOfZ9ZPRLLA9TqN2YOjRV1eXvvq8PMkJ7Ai3k9lmAV/RHCOfR7jF/vpJFegbFN gYjubwBwBWZz4q3TKwmDXOc6Nik68TA= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-663-sWnoyFIKMb6Or-B1Wmp3iA-1; Thu, 23 Jul 2026 11:31:58 -0400 X-MC-Unique: sWnoyFIKMb6Or-B1Wmp3iA-1 X-Mimecast-MFC-AGG-ID: sWnoyFIKMb6Or-B1Wmp3iA_1784820717 Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-738627c7908so151884137.2 for ; Thu, 23 Jul 2026 08:31:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784820717; x=1785425517; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/XuKtYklbAMMLRpHcgZKJLkNu35do35tKSI65PP+qw0=; b=KFsGaady0QKW6lQDLz6pu+h4Fy6nXMNPKrjpx0F2n96A8ewbFezm+tyYqoHZox9n4k mWug1sPYaT3IoVa0ir/7B5InwW44Xq5O9hCFpIVm4X95V6ZvBx7WdRaq4whGFsZ/4VbW B4dkg/HSB4Xe3iUNSyHhzyR1gYH0RZnwJzhpGbesXe3Q2iUyACDKVvFh45ZyB/1IiQr7 E9h/Hcsx6bPz0ECzaUCd+L17IgTQIESv7Uvt6oo0MGPdowILLE1jbWsSp3Q9q3Gx4vhy QL8nqcjgxITOfyqMk1wtkUZVoilNiTzyuGGg2wLNw7YkZkToWERYbt9d10vVcfHga0PF sHOw== X-Forwarded-Encrypted: i=1; AHgh+Robblaba1451pFFy7/8Cdjqgc+yYND663yyh7Cq0nVxDcTXEZ0JWBy1qxUcu/2K9TuuijUxcdqTLuD+rA==@sourceware.org X-Gm-Message-State: AOJu0YyjYWNi86wKo3ODxb+jVVPjKOn52jb22acfAoD/KqqHbW6bkDBd J2x0gTvCZwuuRqZpTfpkV3opjpB6EdlYeqeVh2h+A4e4S4OWHeG8XF1K+QD0MzGzczwUfhL9cnH krcvFTYXw07xlZTn9Y0v/F7e4DILdQO/YbOW1htTm8CI7DKnFQTrFGwtSZsGBcHH+1065lGU= X-Gm-Gg: AR+sD12pbKr6h14usAr18tyNHifKNhzKdoPGxBZweVlYMl9suZfUbTyAX0r02Zwkmjx 2YR879VhzvklRAg5q9ZGyG7BOdqHNvZE/ttUP4DkCzyrQ7C1UbfcmSsutOi35UM1Zkf5NBL9cPe +MSk5+4SXXxXgMQJC8ppUIS8DOGjg/WumgNAUZ97QNcVsx7SeoFXZMdTE/1kuQmFVZaUFwuwYOf N3t7S4ZJnDR320huiVa0RsZ70su6mjd+VIj86LwCiDoVNxei6C/6vyVsefXVsIQgF8fgtpvhbXv gBO+XMAvfKvoczymU8ukLpxWe8Xbe0n69Mk1bjl50U9hRs1ZFT/y64DqfbemJpmd14rTdf1mkhc N7PmmD+KGSA== X-Received: by 2002:a05:6102:4b06:b0:738:bce9:6afc with SMTP id ada2fe7eead31-74d5af3c2a2mr1652972137.0.1784820717223; Thu, 23 Jul 2026 08:31:57 -0700 (PDT) X-Received: by 2002:a05:6102:4b06:b0:738:bce9:6afc with SMTP id ada2fe7eead31-74d5af3c2a2mr1652934137.0.1784820716601; Thu, 23 Jul 2026 08:31:56 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:993e::75d? ([2804:14d:8084:993e::75d]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-74ad31c1fa4sm5282976137.1.2026.07.23.08.31.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jul 2026 08:31:55 -0700 (PDT) Message-ID: Date: Thu, 23 Jul 2026 12:31:51 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Remove some "stabsread" references To: Tom Tromey , gdb-patches@sourceware.org References: <20260716201710.986896-1-tromey@adacore.com> From: Guinevere Larsen In-Reply-To: <20260716201710.986896-1-tromey@adacore.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ji5KmFt-hkX8uJuO9Xb1LAnepZ6TaQlMyMa7nEsWGnk_1784820717 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 7/16/26 5:17 PM, Tom Tromey wrote: > I noticed a stray reference to "stabsread". This patch removes these. > > I also removed a bit of Ada code that, I believe, was only relevant to > the stabs reader. This seems pretty obvious. Especially since the comment in symtab.h (at least to me), implies that m_size is only used for stabsread, so it feels more accurate now. Reviewed-By: Guinevere Larsen > --- > gdb/ada-lang.c | 5 ----- > gdb/gdbtypes.h | 4 ++-- > gdb/symtab.h | 4 +--- > 3 files changed, 3 insertions(+), 10 deletions(-) > > diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c > index 85b08af8c06..b6de3b9e0fb 100644 > --- a/gdb/ada-lang.c > +++ b/gdb/ada-lang.c > @@ -3328,11 +3328,6 @@ ada_index_type (struct type *type, int n, const char *name) > type = type->target_type (); > } > result_type = ada_check_typedef (type)->index_type ()->target_type (); > - /* FIXME: The stabs type r(0,0);bound;bound in an array type > - has a target type of TYPE_CODE_UNDEF. We compensate here, but > - perhaps stabsread.c would make more sense. */ > - if (result_type && result_type->code () == TYPE_CODE_UNDEF) > - result_type = NULL; > } > else > { > diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h > index 572bf6d3d6f..f2132e63e8c 100644 > --- a/gdb/gdbtypes.h > +++ b/gdb/gdbtypes.h > @@ -1611,8 +1611,8 @@ struct fn_fieldlist > { > > /* The overloaded name. > - This is generally allocated in the objfile's obstack. > - However stabsread.c sometimes uses malloc. */ > + This is generally allocated in the objfile's obstack, but it > + could also be statically allocated. */ > > const char *name; > > diff --git a/gdb/symtab.h b/gdb/symtab.h > index 7b96b8c989c..6443216fd7f 100644 > --- a/gdb/symtab.h > +++ b/gdb/symtab.h > @@ -803,9 +803,7 @@ struct minimal_symbol : public general_symbol_info > m_target_flag_2 = target_flag_2; > } > > - /* Size of this symbol. stabs_end_psymtab in stabsread.c uses this > - information to calculate the end of the partial symtab based on the > - address of the last symbol plus the size of the last symbol. */ > + /* Size of this symbol. */ > > unsigned long m_size; > > > base-commit: a9b7bbb1729d5ac6d3623bfe56a54d8b9936f160 -- Cheers, Guinevere Larsen it/its she/her (deprecated)