From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2512 invoked by alias); 27 Oct 2016 14:58:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2494 invoked by uid 89); 27 Oct 2016 14:58:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1780, patience, disappear X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Oct 2016 14:58:11 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8500037E64; Thu, 27 Oct 2016 14:58:10 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9REw9LF004101; Thu, 27 Oct 2016 10:58:09 -0400 Subject: Re: [PATCH 00/13] Split brekapoint_from_pc to breakpoint_kind_from_pc and sw_breakpoint_from_kind To: Yao Qi , "gdb-patches@sourceware.org" References: <1472655965-12212-1-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: Date: Thu, 27 Oct 2016 14:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00762.txt.bz2 On 10/26/2016 04:43 PM, Yao Qi wrote: > On Mon, Oct 10, 2016 at 11:17 AM, Yao Qi wrote: >> On Wed, Aug 31, 2016 at 4:05 PM, Yao Qi wrote: >>> This patch series is to split gdbarch method brekapoint_from_pc to >>> methods breakpoint_kind_from_pc and sw_breakpoint_from_kind. After >>> these changes, new gdbarch methods breakpoint_kind_from_pc and >>> sw_breakpoint_from_kind are more preferred than brekapoint_from_pc. >>> >>> In this patch https://sourceware.org/ml/gdb-patches/2016-05/msg00201.html, >>> I wanted to remove a global variable arm_override_mode, and the >>> discussion leads to a design here >>> https://sourceware.org/ml/gdb-patches/2016-07/msg00211.html In short, >>> we reuse bp_target_info.placed_size as the "kind" of a breakpoint, >>> which can be got by gdbarch breakpoint_kind_from_pc or >>> breakpoint_kind_from_current_state. >>> >>> I choose a way that I can change the code incrementally, and make the >>> review easier. Patch #1, #2, #5, and #8 are obvious, IMO. Patch #7 >>> and #12 do the major work, and the rest are code refactor. >>> >>> Regression tested on arm-linux and x86_64-linux. Tests on other >>> architectures are welcome! >>> >> >> I've pushed patches 1#, #2, and #5 in, because they are obvious. >> Update patch 7 to cover arc. >> So I like this a lot. Thanks again for going through with this all. And thanks for the patience. My only question is what happens to the GDBARCH_BREAKPOINT_MANIPULATION / SET_GDBARCH_BREAKPOINT_MANIPULATION macros? I was hoping they'd disappear in the end, but looks like not? (I find the "manipulation" name to be very opaque here, btw.) Thanks, Pedro Alves