From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79990 invoked by alias); 10 Aug 2017 11:08:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79639 invoked by uid 89); 10 Aug 2017 11:08:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:901, remembered X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Aug 2017 11:08:16 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 689032C96FA; Thu, 10 Aug 2017 11:08:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 689032C96FA Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 476F217DE5; Thu, 10 Aug 2017 11:08:14 +0000 (UTC) Subject: Re: [AArch64][3/6] DWARF unwinder support for signed return address To: Jiong Wang , GDB References: From: Pedro Alves Message-ID: Date: Thu, 10 Aug 2017 11:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-08/txt/msg00210.txt.bz2 On 08/09/2017 01:17 PM, Jiong Wang wrote: > + > + /* Only DW_CFA_GNU_window_save is expected on AArch64. */ > + if (op != DW_CFA_GNU_window_save) > + return false; > + Was there any progress in giving this an Aarch64-specific name to avoid confusion? FYI, I was confused by this again for a couple minutes when I read it, until I remembered the previous discussions. > +/* Implement the execute_dwarf_cfa_vendor_op method. */ > + > +static bool > +aarch64_execute_dwarf_cfa_vendor_op (struct gdbarch *gdbarch, gdb_byte op, > + struct dwarf2_frame_state *fs) > +{ > + struct dwarf2_frame_state_reg *ra_state_column; > + static unsigned char exp_0 = 0x30; /* DW_OP_lit0. */ > + static unsigned char exp_1 = 0x31; /* DW_OP_lit1. */ Can these be static const? (likewise elsewhere in the patch.) Also, gdb_byte. Thanks, Pedro Alves