From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26024 invoked by alias); 23 Oct 2018 09:14:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25869 invoked by uid 89); 23 Oct 2018 09:14:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=H*F:D*ca, H*u:1.3.6, H*UA:1.3.6, H*r:112 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 23 Oct 2018 09:14:34 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w9N9ESDU024203 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 23 Oct 2018 05:14:33 -0400 Received: by simark.ca (Postfix, from userid 112) id 380411EA6D; Tue, 23 Oct 2018 05:14:28 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id A3EA91E50C; Tue, 23 Oct 2018 05:14:27 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 23 Oct 2018 09:14:00 -0000 From: Simon Marchi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] Pass inferior to terminal_inferior In-Reply-To: References: <20181016033835.17594-1-simon.marchi@polymtl.ca> <20181016033835.17594-2-simon.marchi@polymtl.ca> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00497.txt.bz2 On 2018-10-22 16:54, Pedro Alves wrote: > On 10/16/2018 04:38 AM, Simon Marchi wrote: > >> diff --git a/gdb/target.h b/gdb/target.h >> index c37405205a0a..310c942bbe5b 100644 >> --- a/gdb/target.h >> +++ b/gdb/target.h >> @@ -581,7 +581,14 @@ struct target_ops >> TARGET_DEFAULT_RETURN (false); >> virtual void terminal_init () >> TARGET_DEFAULT_IGNORE (); >> - virtual void terminal_inferior () >> + >> + /* If INF shares a terminal with GDB, restore the saved terminal >> settings >> + associated to INF (see terminal_save_inferior) to the current >> + terminal. In a scenario where multiple inferiors share GDB's >> terminal, >> + don't apply the settings of another inferior's settings are >> currently > > s/of/if/. Fixed. >> + applied (in other words, the first inferior's settings win and >> should not >> + be overwritten). */ > >> + virtual void terminal_inferior (inferior *inf) >> TARGET_DEFAULT_IGNORE (); >> >> /* If INF shares a terminal with GDB, save the current terminal >> settings >> > > OK. Thanks. Simon