From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id tmqsBZH/vmgZcTkAWB0awg (envelope-from ) for ; Mon, 08 Sep 2025 12:08:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1757347729; bh=dkYyddPySyhDkpYyDwxVFL/x6kGaA1eCpsib709NZQA=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=mzPcK5IJryUQS7gXSysWmt3EUHlDOtwHmxx3vAwLR5+ZfZc+KE1gHZhmv9Vsuhi4U uMuZdcvnaCOyUi4LKacXhrXUuF35L9eI9dPi+gbrLMzANjQe4NvNPhmd82GmnP8pox UFeRGiBFknq/BOKoEBhXqaUp4FoTmESHwCu5o2kk= Received: by simark.ca (Postfix, from userid 112) id 031771E0BA; Mon, 08 Sep 2025 12:08:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Y/LjGSQs; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4E74B1E04C for ; Mon, 08 Sep 2025 12:08:48 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 13CB8385840E for ; Mon, 8 Sep 2025 16:08:48 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 0D9F33858C53 for ; Mon, 8 Sep 2025 16:08:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0D9F33858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0D9F33858C53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757347708; cv=none; b=TCnBhrl2Wo9adbx8wtuBpWDP1H1MbFA3gvshj3QoAPL/yRCMrjkaraDFDFMhXnwXGXhl3SsxdAYVCSVIU/FfS+pigt9AoE9KrhLr2Q3M2xM0hjN8WpoWUc+u9YRIUs8PysiTWOPTMo5eW3aeWXLAjEUSJffUR3LQ27RDPahfd0k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757347708; c=relaxed/simple; bh=dkYyddPySyhDkpYyDwxVFL/x6kGaA1eCpsib709NZQA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=X3clsPo0QRfKqZuO3Mj11v2orSWNEFXP2dlG+Hk5Ea9/dIJhTjaNfd1HydZZmYFSCb3Id6k0JLi8ZQMHJEFipq+mGmEBnXHYSlM4wS7/Ji2/BjcPKXZjgPFE/GlgbiARSgjrQ8/ut04+jRv4PqWbKD6wIlM6LdaJH8nhgW0zxJw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1757347707; bh=dkYyddPySyhDkpYyDwxVFL/x6kGaA1eCpsib709NZQA=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Y/LjGSQs3kqKUYtMGFyuumQmhGyxRoYtyXoO5qHl2OSGAbI2spgvgBQl7AeEmDnNu WSTttLF1afkBTVK8sBT0D7cjqpHb2ww4wWcl6AeiQ5iwKePWwYkEbfs9Wnx/aFjrI4 Ma3dbBk5Nu8OK1THfAe+E3TBtJPgHokGPckKMKdc= Received: by simark.ca (Postfix) id 623691E04C; Mon, 08 Sep 2025 12:08:27 -0400 (EDT) Message-ID: Date: Mon, 8 Sep 2025 12:08:26 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/7] Move compute_include_file_name earlier To: Tom Tromey , gdb-patches@sourceware.org References: <20250907-breakpoint-cu-expand-v1-0-dd2beef9d475@tromey.com> <20250907-breakpoint-cu-expand-v1-2-dd2beef9d475@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20250907-breakpoint-cu-expand-v1-2-dd2beef9d475@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/7/25 3:29 PM, Tom Tromey wrote: > I noticed that the compute_include_file_name intro comment was > slightly wrong, and while looking at this, I also noticed that it has > a single caller. This patch hoists it slightly so that a forward > declaration isn't needed. Looks fine to me, but it isn't clear from the above if you intended to fix something in the comment (I don't see any changes). Simon