From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MfGLFn3zfmryQSUAWB0awg (envelope-from ) for ; Fri, 14 Aug 2026 06:52:45 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=ewnDMGFb; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=ewnDMGFb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 576071E033; Fri, 14 Aug 2026 06:52:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C3D1C1E033 for ; Fri, 14 Aug 2026 06:52:44 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F3EF94BA900F for ; Fri, 14 Aug 2026 10:52:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F3EF94BA900F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=ewnDMGFb; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=ewnDMGFb Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazlp170110003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c201::3]) by sourceware.org (Postfix) with ESMTPS id E4AE14BA902D for ; Fri, 14 Aug 2026 10:52:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E4AE14BA902D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E4AE14BA902D Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c201::3 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1786704737; cv=pass; b=DIUj+6FtMbrkWEeLQYguSDq+OTGrchFx2+TnWPLejfCp7esgUqCHmF5ib3BMr6CKk0+JyL95+fqBtRxzSes0b0HzAzdZfikLN2ZypoCe0VMzoc978HWIs9bed8HXPT4Cw2XdHVurG4ay9tKSihIwevbLsK373xJebbx7Pf3Ppwc= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1786704737; c=relaxed/simple; bh=W/OUUmmDb0GUPG7ANgz/QSznU6ABHI3BVOkV41dWltM=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=WuU+BVlUAZX/MSD7bAHg7RdezgQlj0nuiyVKJH/pOW5O1fgdMMBZKOAuLCdxgVY1LYLvj9g+hxKqEme1C0g46SDFBfeCpW1qMbYz+cRgHzY6AmYO/ZhfkzzR+W5QT18xBRNiIrmoLnWW+g+b7o3vv+op/6HK669+WrXLPGI0R4Q= ARC-Authentication-Results: i=3; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=ewnDMGFb; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=ewnDMGFb DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E4AE14BA902D ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=RKzSCq+RUu3M4bs6M5Bbwh92xQuEKlzQk+f8rxazwnAmmWtRad3lmfUvbM1UUwXTKbUz0XNQwCeVwC6R5Tbe30kQONOpy+cceDZ39MaVy+I8OxNXfoobNfoRaGsBOGlnmLRZWcxKGP7J4cGWufwIDQ9Tb5CwYKvuw7F/k7ifkaK7UPkrZTE8vtKV5R1yfj0sHjuAMemyVqXMNXGfHQxkisISIl0mjkGJk0a8hqBolvvU79lUnJKOwQvRR3YlUcMw4xtPwjUDWGWH/YNGLn1xgSaH1WwCPlq3Ysv1q99cCiLHoMNVXRxTBBAL6MzAzmRTgrXhAP/ZmkSlE2lqGUh5mA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GLDvhKqkNEbNUf+pRbTze4dNgjcGT9mL1jl74g9iiEQ=; b=aOZjV6jpMZpJxEXwBAB76eSSg4grkt3N2kYgPuq0eC0lKdVG+79/hGO2CGitBRpXhln3ryJfbl72vYvk4KDGHp/bKcYmRDA6IZ2QBh7peC2nGIQQFahlNzUmncx2SlK2MFOo2T6in7ekNl+0Z1fIc5OjMSsZvhsbWnedy21wPBX3jM6hACYi6YTg1P9nNS/aR8iZy2vMWyuVM8f/rdNLjjcVRyVoHK2hk0Y4je2c/UMZVLGiPLzx27GticIgyhzOktpU5L/R1XAOutTa81ERrlvG+XqNWutTJ0qNLi4WtRv5/KyBhL8Gmie8r7MbHVcu2dRgIgGbVWt3RDf4d0JmpA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=simark.ca smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GLDvhKqkNEbNUf+pRbTze4dNgjcGT9mL1jl74g9iiEQ=; b=ewnDMGFbCIYxmVzPtWLLBIjRfIYAzwr17N2OGSzUgsVEya0/RigujejxPY00tojgGzFcvSlzIrIxCuYEwox31XYGsw/dJ3qdWQncbEeMJpCsDkRd/+6amt5lWWQkZjS1D417HYgx4M1wMOs6sT+W97AkY2DXqIY1LL9tJ0lYMVw= Received: from AS4P192CA0012.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:5da::20) by VI0PR08MB10539.eurprd08.prod.outlook.com (2603:10a6:800:208::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.16; Fri, 14 Aug 2026 10:52:10 +0000 Received: from DB1PEPF000509F2.eurprd02.prod.outlook.com (2603:10a6:20b:5da:cafe::33) by AS4P192CA0012.outlook.office365.com (2603:10a6:20b:5da::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.16 via Frontend Transport; Fri, 14 Aug 2026 10:52:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by DB1PEPF000509F2.mail.protection.outlook.com (10.167.242.148) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.339.3 via Frontend Transport; Fri, 14 Aug 2026 10:52:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DlVImRliGzUsC0A03TFvJ5h8a38LW0gAvXbJErTQHuxD8JxAf/cojY8DsMyQoGbPR33CO73HxBK/98F11FS2RBfdbrfSY2McT7BNudzG1f3Oz4ZcJTiENUcpp9be5kjO9Nu/FeeEL831HWi05Y+3DJgyi3iASnTqr+z9a/viWlwL2A6uizQgYfF4bwtt0pHgBsVRNoPMaIaaFrHTuOYauRXexDtw15+j4CZMlAhtueX0LJAm6pHV4yOBUHy4msfmNU2AI5I06UewTGmgg2p/2xa9BkObWZclbk89C8nbtFOxa8F4M1j9LStLy0tJoqyF0hA4QyNseK8meWrFCMnPSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GLDvhKqkNEbNUf+pRbTze4dNgjcGT9mL1jl74g9iiEQ=; b=M272GbRTem+jTtPYIenNU40CPhfpGj/tAVDp6Hl+f2uSdNNC5jnr4i8qZVbGhZQ2qEZCAUXpgb+fgw19JjksaA/zvtdnsokkQagZdvX3/7mtXYfc+yio39pbxk6+fHI/PFYfhjkcdlCd6YP8tr5Gfhgq0fvvxksr+BVvnb2ggYCVbZvWbabvn9kmo6zlRN7iaTultWAwJJzOTGkIAmzm2WcFtljVOV8bFlS6KVK13Z2waag8DfLGCDTXWASwjINLoi9Iue3SQ4x/0zva7AQ5QhLh8xJqAUg5mmzKg8sH9xBb6K8GnGo7w/ex2W3pGCYkwfpNqT4qkUHsHKjVPFFt/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GLDvhKqkNEbNUf+pRbTze4dNgjcGT9mL1jl74g9iiEQ=; b=ewnDMGFbCIYxmVzPtWLLBIjRfIYAzwr17N2OGSzUgsVEya0/RigujejxPY00tojgGzFcvSlzIrIxCuYEwox31XYGsw/dJ3qdWQncbEeMJpCsDkRd/+6amt5lWWQkZjS1D417HYgx4M1wMOs6sT+W97AkY2DXqIY1LL9tJ0lYMVw= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from GV1PR08MB8667.eurprd08.prod.outlook.com (2603:10a6:150:85::13) by GV1PR08MB11165.eurprd08.prod.outlook.com (2603:10a6:150:1f3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.16; Fri, 14 Aug 2026 10:51:33 +0000 Received: from GV1PR08MB8667.eurprd08.prod.outlook.com ([fe80::ae9c:f011:dbb4:c095]) by GV1PR08MB8667.eurprd08.prod.outlook.com ([fe80::ae9c:f011:dbb4:c095%2]) with mapi id 15.21.0315.014; Fri, 14 Aug 2026 10:51:32 +0000 Message-ID: Date: Fri, 14 Aug 2026 11:51:31 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] gdbtypes: improve documentation of composite type helpers To: Simon Marchi , gdb-patches@sourceware.org References: <20260813172736.500755-1-matthieu.longo@arm.com> <501a7d7b-df70-4d66-88c6-ad6fbe4e7e49@simark.ca> Content-Language: en-US From: Matthieu Longo In-Reply-To: <501a7d7b-df70-4d66-88c6-ad6fbe4e7e49@simark.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P123CA0032.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2fe::7) To GV1PR08MB8667.eurprd08.prod.outlook.com (2603:10a6:150:85::13) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: GV1PR08MB8667:EE_|GV1PR08MB11165:EE_|DB1PEPF000509F2:EE_|VI0PR08MB10539:EE_ X-MS-Office365-Filtering-Correlation-Id: abcc9a5c-8059-412b-de1a-08def9f2171f x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|376014|1800799024|23010399003|366016|6133799003|56012099006|10067099003|11063799006|4143699003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info-Original: ZJyy6FGSOVuBLa1OOifY9EQ4bN/DMeyGYuJKTIHBxBRnSYpgt1cAmr+QeJAjypTP0WIqUihR0tFdDUPIrHtSjzQPbdDdh0OOHApmlv6loxpAWWNP2k28NZWkz8I+6Dwy9wC9Sm2BMOjXnRCYckQ34S1heCWj/HBWuTIYS4sYz5oxExf4kxk44m286OXLT/WJVeBTkVDLmk1gzwOcfWV4SNwVgh/CrMdLi9GQ9rrV6AJcXtBg0nqNqUkPFY3Mu/K1VlcKs4XOvnJyu6e/RNL70AXVx5sayhjRFwkLLjCg/fmzOiL1G3Ayy+PuW6Sle4gQiiBb7m2NE/LOtveve5eT6MQR5d2Z5nDysXAuGYmE90oiQh8mzgOGpOpozMKWHmZBrElPN0bmT2TMX4P/B6SzuQPUr57b5kKWZtGku/3ZxkxS9aAtQ3cHlsNEPD2sB0/ZmcU6S/8SMeG9r9zenCJA4R45tenRfAYOgbpifkN9QDFStGPCrtHRlql84ZrlBLZCIZGAKHVgfvE7Tr9H11+Fo9RMzohgXOPEKqNWoMWfS50brHUnFlB5ylHVBy6gS3ntZYuRmpZ7h+e7MLHFR17ogNkVdoLChttCdbSppwaLU433577qbbnFmBwA2R41pWjXvEtaUJXcX+yow+ceJPpXZabOEozrIZloLpx0+WDfJaQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:GV1PR08MB8667.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(23010399003)(366016)(6133799003)(56012099006)(10067099003)(11063799006)(4143699003)(22082099003)(18002099003); DIR:OUT; SFP:1101; X-Exchange-RoutingPolicyChecked: G9GJ0V/EJASkPpI8rFPF7v3FU07l8g7atpIPVl2aBWW+9vc4rAeXncDxnjlVDHfKmHQp4sZsbElnQ36kL0421MrCtS4kBm9PbJuN5+wcQ7zVI7wQNdN9A8nchetayt0EXjE/Z19RQUzDJCVAi/mRejFs9Lpbsjknzox7iMt7X7coVjaeD0xAvxYq9z/fVU7rAn2KBPoT3EIJ40N/6oE4fLoiy+uy193mSzMx9h5kz9gdkMMRn91gY3Pl4h57eWG4Tpi8xm/FZSmgieYr6hImqUeYmPJ2vYJITh4biidrTWtX3rqpy13uGDG6zzWTfOaZJ3X7PVFkZKl2xSpFCaDcmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB11165 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB1PEPF000509F2.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2794ac0c-49cf-4837-62d1-08def9f200d6 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700016|82310400026|376014|23010399003|35042699022|1800799024|14060799003|13003099007|6133799003|11063799006|56012099006|10067099003|4143699003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: KvHCq/F3fLIVScCo26acd49ZlT12/sS8Kvu46J6nZ2tWVlsHTo4JABTEhpxZMmWx3aNx50t5i+JuM+1wbwP0OS/KS10jL/ENziQ7oXx/6YoGida5MtlCBX2xwCYSAsgSEWWZKpuwNeeAGIBpw0QQkkEBktnELVE1qwTbIZOwzQGhsaW8kNL0/dWQDFx+lh0b4n0Ofr5Xnz9B5GWmP+sq1r4gZ9oSEncJt2y4R2WTgxW/TKGK/vcLiH1qkRoV3G8M0jdKK8GJx9iz56A6kur94R9yrMBtPvgLIysedwNvsiQhtP949RdcWQ3YDtOrYrGea6OasNo4J8iejyHMDnO5+FFk+wTKUun0V1Rwh3a7PqG7s5ZNvJduMKoB4oeF9+2gjFeAzUrMPnNWzPohJHuSQn1duL6liUGyLwow7iSqKz717sV8HcbQjuTk1YsgwgxjakR6KOjR5d3dHf4b3a9k/xPHT3Mln3+5DooSMB0HItdaA8eeQvai0dMGhemWdd20q+ZEZ+bXpyJiR8/udBImdOfo8//X8uCZ2qKBCEdhgs7xFOF6nJ1C2v5XWg/1TK9pTr48qmsOY/56WH2qjjVbc4T2ABcLn+dp1twLN0gVuYlY9ycCf25z/hO9pB/9PSWQMbNGsCqcRSkFyVpnwW/Hwm1C+/RZMWSkvuy74Je84gAQmjxBQ7Sn0aelUUWPKC26taA8iXTnN5YoZSqYEU2IPg== X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(36860700016)(82310400026)(376014)(23010399003)(35042699022)(1800799024)(14060799003)(13003099007)(6133799003)(11063799006)(56012099006)(10067099003)(4143699003)(18002099003)(22082099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: gmMPXEP5ZDcSfIYCxkVo7/uKzcgugf6/W2XJWwKPIsZZ9tmIABCK/tKVOOo11sReYSJkbqFhnoJwUJbpUrkeUk2nrEbfNETR1mgrzXr4gBw5skqLBiQDVAHzUHHuKpb+9INDy9yS7fJbfKJaCD81BEDKNk6oRXaTfe1OeUy5k9DV36widVdge5bPB5lJcruSkMSycyRPqGaZP2k/0PzEW9JXfwybU/wZdhFOHqP7DE81SEd3Mb6WGEf8UTThLyUfPT6byfawKFkqnxUxE3DjjajNNJ5flfwNFsb3vnGaA9z7DYbruOQzwpjTilaEGLCiV81lYisfeYr+Mkt1Cz1+rqQ2VOf/cZuqCj57sPRen/wm3LFkBbdKBDaTSLE7jOnc8YH3ohu6OMtmMAAZ1gJs2bPFxt+LUNaLM+oHZ4OK7R4f7GtfrO5tUI9QTaMHvL8l X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2026 10:52:09.8088 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: abcc9a5c-8059-412b-de1a-08def9f2171f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509F2.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR08MB10539 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 14/08/2026 05:17, Simon Marchi wrote: > On 8/13/26 1:27 PM, Matthieu Longo wrote: >> Document how arch_composite_type handles a null NAME, and clarify the >> semantics of a null or empty field name for the append_composite_type* >> helpers. >> >> Suggested-By: Simon Marchi > > Thanks for the patch! > > It would be a good time to clean things up a bit, to bring them up to > the current standard. The comments in the .c file should just be: > > /* See gdbtypes.h. */ > > And the proper comments should be moved to the .h file. > >> @@ -5428,9 +5429,11 @@ arch_composite_type (struct gdbarch *gdbarch, const char *name, >> return t; >> } >> >> -/* Add new field with name NAME and type FIELD to composite type T. >> - Do not set the field's position or adjust the type's length; >> - the caller should do so. Return the new field. */ >> +/* Add a new field named NAME with type FIELD to composite type T. >> + This function does not set the field's position or adjust the length of T; >> + the caller is responsible for doing so. If NAME is nullptr or an empty >> + string, the field represents an anonymous struct or union whose fields >> + are visible directly in the parent scope. Return the newly added field. */ >> >> struct field * >> append_composite_type_field_raw (struct type *t, const char *name, > > I don't think that a field NAME can be nullptr. For the "search through > anonymous structs/unions" code to work, the name specifically needs to > be a non-nullptr empty string: > > https://gitlab.com/gnutools/binutils-gdb/-/blob/a760a797aeb6e9143d60f0b8b2b8f71da88cabcf/gdb/valops.c#L2014-2015 > > And I don't think it's actually safe to pass nullptr. When I try to > change one of the siginfo fields to have a nullptr type, GDB crashes > here: > > #2 0x00007efd9800ded2 in __ubsan_handle_nonnull_arg_abort () from /usr/lib/libubsan.so.1 > #3 0x000055fa5ad2f2a5 in ui_file::puts (this=0x7b1d93e02310, str=0x0) at /home/smarchi/src/binutils-gdb/gdb/ui-file.h:77 > #4 0x000055fa5e47b89d in gdb_puts (linebuffer=0x0, stream=0x7b1d93e02310) at /home/smarchi/src/binutils-gdb/gdb/utils.c:1912 > #5 0x000055fa5e47bb9d in fputs_styled (linebuffer=0x0, style=..., stream=0x7b1d93e02310) at /home/smarchi/src/binutils-gdb/gdb/utils.c:1928 > > I think it would be safer to just say "empty string" here. > > For types, I think that the name can be nullptr: it's possible to create > a type and never call set_name on it. > > Simon Addressed the above comments in v2. https://inbox.sourceware.org/gdb-patches/20260814104941.522777-1-matthieu.longo@arm.com/ Matthieu