From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 3FBD1388700B for ; Thu, 9 Apr 2020 01:00:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3FBD1388700B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 736151E5F9; Wed, 8 Apr 2020 21:00:01 -0400 (EDT) Subject: Re: [PATCH v3] Add SVR4 psABI specific parser for AUXV entries To: Kamil Rytarowski , gdb-patches@sourceware.org Cc: tom@tromey.com, jhb@FreeBSD.org References: <20200408145832.24243-1-n54@gmx.com> <20200409005630.25839-1-n54@gmx.com> From: Simon Marchi Message-ID: Date: Wed, 8 Apr 2020 21:00:01 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200409005630.25839-1-n54@gmx.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Apr 2020 01:00:03 -0000 On 2020-04-08 8:56 p.m., Kamil Rytarowski wrote: > NetBSD and OpenBSD always use an int to store the type as > defined in the SVR4 psABI specifications rather than long > as assumed by the default parser. > > Define svr4_auxv_parse() that shares code with default_auxv_parse(). > > Remove obsd_auxv_parse() and switch OpenBSD to svr4_auxv_parse(). > Remove not fully accurate comment from obsd-tdep.c. > > Use svr4_auxv_parse() on NetBSD. > > gdb/ChangeLog: > > * auxv.h (svr4_auxv_parse): New. > * auxv.c (default_auxv_parse): Split into default_auxv_parse > and generic_auxv_parse. > (svr4_auxv_parse): Add. > * obsd-tdep.c: Include "auxv.h". > (obsd_auxv_parse): Remove. > (obsd_init_abi): Remove comment. > (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument > from `obsd_auxv_parse' to `svr4_auxv_parse'. > * nbsd-tdep.c: Include "auxv.h". > (nbsd_init_abi): Call set_gdbarch_auxv_parse. > Thanks, this is ok. Simon