From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4O3LBvkUeWdkyAIAWB0awg (envelope-from ) for ; Sat, 04 Jan 2025 06:01:13 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=SWhvL0MI; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=dU+KGU7N; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=rhsIe8ms; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=j18y9fQ+; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 17C151E097; Sat, 4 Jan 2025 06:01:13 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 975901E05C for ; Sat, 4 Jan 2025 06:01:12 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4E6E53858D3C for ; Sat, 4 Jan 2025 11:01:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4E6E53858D3C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=SWhvL0MI; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=dU+KGU7N; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=rhsIe8ms; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=j18y9fQ+ Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 3D9873858D20 for ; Sat, 4 Jan 2025 11:00:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3D9873858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3D9873858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1735988432; cv=none; b=OtAHIR03rRG19ScQeFhwIxYEyWVr9pRD1JjNMzVpb1QhUlfhsWrMA0dEgloyCFwqCqXjJeHvzFU4x9/UVr5ehG1/04A2m5yUBy0Nw4ckQ/eAjJqhDdQM96IpvYj4QsDGHmSe402lVn9e6Ve5r/omBILA0poFqiIspYTN+Kj+zXY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1735988432; c=relaxed/simple; bh=US0YFhJNHEdwY8m2adFSBcicdUcdoG2t7Gkq12aU7kA=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=D2S+NWjQqQkjF15+6zhmK5QeaX4Jp/WxxWwN4d57OJ0zSNdSmB3fWjfiNGsHO9GajRdCFcrG7woHVdfKcgwtJc48PHtrV4LmKbQypKhumaLKfmx+Lu1GaOJuKEpCIbE2XR9YY1Qq1g/nTHEfFy7pS7E+laEbinZ2A46g1rEVqrc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3D9873858D20 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D4B8921137; Sat, 4 Jan 2025 11:00:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1735988431; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6WDYQJGFutxLfmKDJVaRjSpZpEe96Yt7x8g3sRRdTSg=; b=SWhvL0MItzp2f/PVuq38437qNhnIDmMKzkuFuR2W+lTjluoTGNKyjMBFmlzTA2csqIawsO Ts3GtaLoCCf4OdoJBaLOvoc2KzDW/4xXlsuAx2OLtOGn884ZkSlHtlxrIMwTk43rbITsFp mY1yS4zRCYAS2rJf0VbcpsCBBL6lQbg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1735988431; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6WDYQJGFutxLfmKDJVaRjSpZpEe96Yt7x8g3sRRdTSg=; b=dU+KGU7Nz/xoj9UjI2vlxy50ACqafQZhaH42mx/BHEji9IALDBnMUT3JnuMthiYixlkHvL uWZaDAMsPDmlU+Aw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=rhsIe8ms; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=j18y9fQ+ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1735988430; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6WDYQJGFutxLfmKDJVaRjSpZpEe96Yt7x8g3sRRdTSg=; b=rhsIe8mselpV6RVWRiTEGHEngKJzOoCcBKBBJn2xdS/G4GfxbrtUQcJn/c1Ygzd6RbQ/yi etHOESRQ/1pW/buQF+UmupDRoY0P8WoH2FBFEZSGriYoXAlCA/TPjCjtZsIY1GK0sMFiUl ra6OmqHPPFYlqB91Z9I8Cidaxmbd9wY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1735988430; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6WDYQJGFutxLfmKDJVaRjSpZpEe96Yt7x8g3sRRdTSg=; b=j18y9fQ+apCaBURBt9//Gjtci3/30lhSKVGfad4ZgOeqrDrUSKYi3aNxtyrbfR+9lfq7BA dUf9DAQgm2J4+jBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AC354134E4; Sat, 4 Jan 2025 11:00:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id A+aSKM4UeWcqcQAAD6G6ig (envelope-from ); Sat, 04 Jan 2025 11:00:30 +0000 Message-ID: Date: Sat, 4 Jan 2025 12:00:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: GDB 16.0.90 available for testing To: Eli Zaretskii , Luis Machado Cc: brobecker@adacore.com, gdb-patches@sourceware.org References: <20241229033130.D7F7F803EA@takamaka.gnat.com> <868qryr6nn.fsf@gnu.org> <864j2hjers.fsf@gnu.org> <2b81a853-d925-48e7-8e38-d8584f568cde@arm.com> <86zfk6eur9.fsf@gnu.org> Content-Language: en-US From: Tom de Vries In-Reply-To: <86zfk6eur9.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D4B8921137 X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; TO_DN_SOME(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 1/4/25 11:30, Eli Zaretskii wrote: >> Date: Fri, 3 Jan 2025 10:05:14 +0000 >> Cc: gdb-patches@sourceware.org >> From: Luis Machado >> >> On 1/2/25 17:40, Eli Zaretskii wrote: >>>> Date: Sun, 29 Dec 2024 14:54:36 +0200 >>>> From: Eli Zaretskii >>>> Cc: gdb-patches@sourceware.org >>>> >>>> 2. Compilation error in event-top.c: >>>> >>>> >>>> CXX event-top.o >>>> In file included from d:\usr\include\winsock2.h:69, >>>> from ./../gdbsupport/gdb_select.h:30, >>>> from event-top.c:43: >>>> event-top.c: In function 'fd_set* fd_copy(fd_set*, const fd_set*, int)': >>>> event-top.c:1279:22: error: invalid conversion from 'const fd_set*' to 'fd_set*' [-fpermissive] >>>> 1279 | if (FD_ISSET (i, src)) >>>> | ^ >>>> | | >>>> | const fd_set* >>>> d:\usr\include\winsock.h:164:50: note: initializing argument 2 of 'int __FD_ISSET(SOCKET, fd_set*)' >>>> 164 | __CRT_ALIAS int __FD_ISSET( SOCKET __fd, fd_set *__set ) >>>> | ~~~~~~~~^~~~~ >>>> >>>> I solved it with an explicit cast, like this: >>>> >>>> --- gdb/event-top.c~0 2024-12-29 04:50:07.000000000 +0200 >>>> +++ gdb/event-top.c 2024-12-29 12:33:48.356713700 +0200 >>>> @@ -1276,7 +1276,7 @@ fd_copy (fd_set *dst, const fd_set *src, >>>> { >>>> FD_ZERO (dst); >>>> for (int i = 0; i < n; ++i) >>>> - if (FD_ISSET (i, src)) >>>> + if (FD_ISSET (i, (fd_set *)src)) >>>> FD_SET (i, dst); >>>> >>>> return dst; >>>> >>>> But I don't know if this will produce problems for other >>>> implementations of FD_ISSET. >>> >>> No one responded to this part. Is it okay to fix this, or would >>> someone please try this first on other platforms? >>> >> >> I gave this a try on aarch64-linux and it builds fine. I see no changes to the >> testsuite. >> >>>> 4. Running "maint selftest" finds one failure: >>>> >>>> Running selftest help_doc_invariants. >>>> help doc broken invariant: command 'signal-event' help doc has over-long line >>>> Self test failed: self-test failed at unittests/command-def-selftests.c:121 >>>> >>>> I fixed that with the following trivial change: >>>> >>>> --- gdb/windows-nat.c~0 2024-12-29 04:50:07.000000000 +0200 >>>> +++ gdb/windows-nat.c 2024-12-29 12:54:32.346946000 +0200 >>>> @@ -3114,9 +3114,9 @@ _initialize_windows_nat () >>>> >>>> add_com ("signal-event", class_run, signal_event_command, _("\ >>>> Signal a crashed process with event ID, to allow its debugging.\n\ >>>> -This command is needed in support of setting up GDB as JIT debugger on \ >>>> -MS-Windows. The command should be invoked from the GDB command line using \ >>>> -the '-ex' command-line option. The ID of the event that blocks the \ >>>> +This command is needed in support of setting up GDB as JIT debugger on\n\ >>>> +MS-Windows. The command should be invoked from the GDB command line using\n\ >>>> +the '-ex' command-line option. The ID of the event that blocks the\n\ >>>> crashed process will be supplied by the Windows JIT debugging mechanism.")); >>>> >>>> #ifdef __CYGWIN__ >>> >>> And what about this one? okay to commit? >> >> This looks OK to me, as it is a simple formatting fix for the text. Feel free to >> push to master and the 16 branch. >> >> Approved-By: Luis Machado > > Thanks, I've now installed both changes on the master branch and then > cherry-picked them to gdb-16-branch. Hi Eli, thanks for fixing this. I suspect that this should be done using a const_cast though, I've submitted a follow-up patch implementing that ( https://sourceware.org/pipermail/gdb-patches/2025-January/214463.html ). Thanks, - Tom