From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id TrpzGlZiKWXIySwAWB0awg (envelope-from ) for ; Fri, 13 Oct 2023 11:29:26 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-armh-onmicrosoft-com header.b=aD2toP8Y; dkim=pass (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-armh-onmicrosoft-com header.b=aD2toP8Y; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 63C311E0C1; Fri, 13 Oct 2023 11:29:26 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 540201E00F for ; Fri, 13 Oct 2023 11:29:24 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F0E65385703A for ; Fri, 13 Oct 2023 15:29:23 +0000 (GMT) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2058.outbound.protection.outlook.com [40.107.21.58]) by sourceware.org (Postfix) with ESMTPS id 0138A3858D1E for ; Fri, 13 Oct 2023 15:29:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0138A3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Frxygibe8w+wkIQb4Sjq4/KQv4MqWqvPDX9yLcW76oQ=; b=aD2toP8YBALLokTjZdwmu1ClnT7B9VIdZgHJ+j+HN0yZJOCEyRhHbqxuIK9WR4fwy1g5YyrBqIWYLo4oL66ePfdVPSaoWMjmJF05wb6DNC9g6/ngxdUKnZK8ejJImDiaojqRW9LoCYAP/MEDpNK5a6kdrRqFwZkI6WReeIjgeW8= Received: from DUZPR01CA0090.eurprd01.prod.exchangelabs.com (2603:10a6:10:46a::8) by DU0PR08MB10357.eurprd08.prod.outlook.com (2603:10a6:10:414::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.45; Fri, 13 Oct 2023 15:29:08 +0000 Received: from DU6PEPF00009525.eurprd02.prod.outlook.com (2603:10a6:10:46a:cafe::31) by DUZPR01CA0090.outlook.office365.com (2603:10a6:10:46a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.30 via Frontend Transport; Fri, 13 Oct 2023 15:29:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DU6PEPF00009525.mail.protection.outlook.com (10.167.8.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.22 via Frontend Transport; Fri, 13 Oct 2023 15:29:08 +0000 Received: ("Tessian outbound ab4fc72d2cd4:v211"); Fri, 13 Oct 2023 15:29:08 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 2568dae94fceae67 X-CR-MTA-TID: 64aa7808 Received: from 2438eef4dd8c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D1E74122-4F01-43FA-A5C7-F78A3EB50ADF.1; Fri, 13 Oct 2023 15:29:02 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2438eef4dd8c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 13 Oct 2023 15:29:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kawNtBZgB/1szr55/OGv8iZkhQlK6+1ajRhC6wQJUmU1vqqnvm7a0GpYwuTHVFYVEgmOmiDvUaV4WqQ4xxCnRqrRJNtrdkZlx6gbVB7R5dmMlRdb6q68ihLi16oNnp3vjyThGF5mI9rqrFZweFfdTN199+2wsMz5wJGQxekNDmJpumFe92Nj+zpLmhK3pOtPJFq0kWq6/tLG3DhQt+uVLueJ+L3pl2Se1LyHpIDQsHpBUx3+KoI6HlMp/jqfeJBYWuhZtNWqJv0LPxMGd4dFfRbzuxpZSJSCdYM53ta+d25LkosfMcv/WaKXsSqmP6wVkjoyTAtjzy+OkQu0Z1taOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Frxygibe8w+wkIQb4Sjq4/KQv4MqWqvPDX9yLcW76oQ=; b=BDClfMuHnnuujEGxKI34QRMw+5GEK/efAzrNe11RlAOctPLLJp7zlDuTuOEMvC9Qu7F+Sl/3FVmAOjwEzAlU9PDk+kJbIUEOKZMhg6lMvYya7gU/DNgDDL1dMY86zYjd7JK4QFiJvXXRR9s75XhB9reCYCRZF85Jd+qv797Y9PQEqlzJJoDgf5//71O98jdTWEBIx7CV6nePQ0ysNhuvuBeYPGEEB6pI9BaFWgjUHWdBtcLyIqfopAqeJ0DKAQ7rtIm+OlsVjWflPpAtOC66NW/Iusy/1EUyrfH8T9iRD3KkiQoIOUohz/x6P83LEIXTVUUgDReWcHW0aQ1wK79EWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Frxygibe8w+wkIQb4Sjq4/KQv4MqWqvPDX9yLcW76oQ=; b=aD2toP8YBALLokTjZdwmu1ClnT7B9VIdZgHJ+j+HN0yZJOCEyRhHbqxuIK9WR4fwy1g5YyrBqIWYLo4oL66ePfdVPSaoWMjmJF05wb6DNC9g6/ngxdUKnZK8ejJImDiaojqRW9LoCYAP/MEDpNK5a6kdrRqFwZkI6WReeIjgeW8= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DB9PR08MB9923.eurprd08.prod.outlook.com (2603:10a6:10:3d1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.45; Fri, 13 Oct 2023 15:29:00 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c126:1009:20a5:195]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c126:1009:20a5:195%4]) with mapi id 15.20.6863.032; Fri, 13 Oct 2023 15:29:00 +0000 Message-ID: Date: Fri, 13 Oct 2023 16:28:57 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [aarch64] Use SVE_VQ_BYTES instead of __SVE_VQ_BYTES Content-Language: en-US From: Luis Machado To: gdb-patches@sourceware.org, tromey@adacore.com References: <20231013152655.2435663-1-luis.machado@arm.com> In-Reply-To: <20231013152655.2435663-1-luis.machado@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0040.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::28) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|DB9PR08MB9923:EE_|DU6PEPF00009525:EE_|DU0PR08MB10357:EE_ X-MS-Office365-Filtering-Correlation-Id: ed10a75b-6e79-4314-ff40-08dbcc0124bb x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: JsCEu273yCKRiNd1sHuvuQWs4GNWYS4lP87X8zdGk0MvWUSVQQIhvqZLN/HSlSDuJJ3Fl6eCiCR2WMi5cSMKTCbjb/gbVuA16N6JmArD54L8HBbi73k1AAtj7al9YC6HKu/gQfTyhELhRYQtWXhJt6B5vT9X/fkI1w31SaPeIY0TKexXZMJRrMIy5NhxYdc/7IJ4NJvE8Iwd/ovKbPxfBbjUPe86t1zi8qmjCtKGECtbGXTiVZjnLcfuIdlhKVkLZV+yuHTim1TEwWM0MgN4ioqZdrJzlIxqi26PKQ/C9cGylaJ6h/fVScUqMqUrooISC8EpARazwmEsNlLGqQ5ooMrXgZPSpkQ7dIZ39jIWlvGf1MS8+OV2IKGvpwJAd8PCBqj1v2CVDh89nsuYrOR5xzKNBTCethxgVUmLrsCvpn+/c10+4vTQImciDFoHHjRQojGxmPLhHyXsAKxZ4E7yatTlUpAC4jgxiGMUJflOhLI5OXI7G4Yr/M15sXrNohhvVXGmmc3FRyRUCRtn8OEHo8fbb57C0Iu7SySH2z6xWlf6WGbY+1dKc9xPqKHE8JAAazgyhYVbYJV55LW6VJYaHJRi7JH+r7aSQRNs30GigOhDTDA8dSEeOektE/ZQlo3NotkMnevoAOXjk32nb2G59w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(136003)(396003)(366004)(376002)(346002)(230922051799003)(451199024)(1800799009)(64100799003)(186009)(8676002)(6512007)(26005)(66476007)(2616005)(6486002)(5660300002)(6666004)(41300700001)(44832011)(8936002)(86362001)(2906002)(31696002)(36756003)(66556008)(66946007)(316002)(53546011)(6506007)(478600001)(31686004)(38100700002)(83380400001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9923 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU6PEPF00009525.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9d265f45-ec15-4a61-7d47-08dbcc011fcd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /4uT/8jSuAy8ELJ0PGMPNRpQJc8nV6uUg3v0ugchqGC1+8eKal7HzamjSpYF3DNxBrVnKt7npmn4bZrIJkSMGmzCIjeXF4AMBdz1zzigcSdLmdKLw2rbIP4C2SfOw+iV13Mq5AfSt58p0oZt8TmAM0w/hKPpCjbJqJURWzYQXJE/Q70I+WVxPizQOcQ/Ebb0zGc43vnbM7oYnywqGaAlYXF4VvFrHx0/7wbHFtUBUW83wE17xs2BP99+XQS16yjQho8l+2Zt0Mvxo4LmUcSic97vOMyHo1ZUa3Q4ng8NRxhUA1WCum7imYpHgzBgTmiDh8hbgUyCNVgBqZEli4KrYFPXrxoN1pMZnD4DOzHC4R3w3kJRy8szSm8uI/pw81brpCVClsfV68maiXGaANSz2QkYNzfWN49dwUDCMPLTdj6NPbxyaCvOow7kpgFnGrFTzv0+sQVO+Arc2iR0jiA6NtWt/XNS935Mv6+Bkfv4MeeFs414UD+RvtTS+AFwMb5PnyO2rvNlfpjxWMoPvoqBz/tqvN4uO9UsNZx9uWSw5okxhcBuXpnwxwhBHaP8U60SN5x4JcmslFC07IL5wEsAM2wZiIcAKsuTzmh+OhQbglcMxPP37/50F/RLU+4A5i2WN+jljIlqhRTKZ5rpw0nsg+lPMl+bGjqUgJYlmI/FOSn37vz95dBixAdIttKJI+FJH8iKHxp+I/vLUMH43vJfRLQ489PYvgks7eoykzKPcYGbRLwHn6yRFrk0bzNU6R6zaf5/pFwJ5mgO3RSu+B86Xw== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230031)(4636009)(396003)(39860400002)(136003)(346002)(376002)(230922051799003)(451199024)(82310400011)(1800799009)(64100799003)(186009)(46966006)(40470700004)(36840700001)(40480700001)(6512007)(40460700003)(26005)(336012)(2616005)(81166007)(82740400003)(6486002)(356005)(5660300002)(8676002)(8936002)(44832011)(86362001)(2906002)(31696002)(41300700001)(36756003)(70586007)(6666004)(70206006)(316002)(53546011)(6506007)(478600001)(47076005)(36860700001)(31686004)(83380400001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2023 15:29:08.6078 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ed10a75b-6e79-4314-ff40-08dbcc0124bb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DU6PEPF00009525.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB10357 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 10/13/23 16:26, Luis Machado wrote: > __SVE_VQ_BYTES is only available if SVE definitions are available in > the system's headers, and this is not true for all systems. > > For this purpose, we define SVE_VQ_BYTES. This patch fixes the > name of the constant being used. > > --- > gdb/nat/aarch64-scalable-linux-sigcontext.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gdb/nat/aarch64-scalable-linux-sigcontext.h b/gdb/nat/aarch64-scalable-linux-sigcontext.h > index 18623443744..7c858294ac9 100644 > --- a/gdb/nat/aarch64-scalable-linux-sigcontext.h > +++ b/gdb/nat/aarch64-scalable-linux-sigcontext.h > @@ -301,8 +301,8 @@ struct user_za_header { > > /* Offset from the start of struct user_za_header to the register data */ > #define ZA_PT_ZA_OFFSET \ > - ((sizeof (struct user_za_header) + (__SVE_VQ_BYTES - 1)) \ > - / __SVE_VQ_BYTES * __SVE_VQ_BYTES) > + ((sizeof (struct user_za_header) + (SVE_VQ_BYTES - 1)) \ > + / SVE_VQ_BYTES * SVE_VQ_BYTES) > > /* The payload starts at offset ZA_PT_ZA_OFFSET, and is of size > ZA_PT_ZA_SIZE(vq, flags). > @@ -317,9 +317,9 @@ struct user_za_header { > systems: see sigcontext.h for more explanation. */ > > #define ZA_PT_ZAV_OFFSET(vq, n) \ > - (ZA_PT_ZA_OFFSET + ((vq * __SVE_VQ_BYTES) * n)) > + (ZA_PT_ZA_OFFSET + ((vq * SVE_VQ_BYTES) * n)) > > -#define ZA_PT_ZA_SIZE(vq) ((vq * __SVE_VQ_BYTES) * (vq * __SVE_VQ_BYTES)) > +#define ZA_PT_ZA_SIZE(vq) ((vq * SVE_VQ_BYTES) * (vq * SVE_VQ_BYTES)) > > #define ZA_PT_SIZE(vq) \ > (ZA_PT_ZA_OFFSET + ZA_PT_ZA_SIZE(vq)) Pushed now. This should fix native builds of aarch64 gdb/gdbserver when SVE headers are not available. Please let me know if you see any other issues.