From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98399 invoked by alias); 3 Oct 2018 17:28:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 98386 invoked by uid 89); 3 Oct 2018 17:28:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=triggering X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Oct 2018 17:27:59 +0000 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A889B5D669; Wed, 3 Oct 2018 17:27:58 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0EC2B20155EE; Wed, 3 Oct 2018 17:27:57 +0000 (UTC) Subject: Re: [PATCH v2 02/10] Change dwarf2_frame_state_reg_info::reg to be std::vector To: Tom Tromey , gdb-patches@sourceware.org References: <20181002044420.17628-1-tom@tromey.com> <20181002044420.17628-3-tom@tromey.com> From: Pedro Alves Message-ID: Date: Wed, 03 Oct 2018 17:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181002044420.17628-3-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-10/txt/msg00074.txt.bz2 On 10/02/2018 05:44 AM, Tom Tromey wrote: > This changes dwarf2_frame_state_reg_info::reg to be a std::vector. > This avoids undefined behavior in the copy constructor when the > original object does not have any registers. I don't have anything to say against the patch, I think it's a nice cleanup regardless, but could you expand this log a little to point out exactly what is triggering the undefined behavior. I guess we're passing NULL to the memcpy? LGTM otherwise. Thanks, Pedro Alves