From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CAhQBkbFQWjxJgIAWB0awg (envelope-from ) for ; Thu, 05 Jun 2025 12:26:46 -0400 Received: by simark.ca (Postfix, from userid 112) id 087B01E102; Thu, 5 Jun 2025 12:26:46 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.0 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 911CB1E0C2 for ; Thu, 5 Jun 2025 12:26:45 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 31A23385843D for ; Thu, 5 Jun 2025 16:26:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 31A23385843D Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by sourceware.org (Postfix) with ESMTPS id 0DA823858D34 for ; Thu, 5 Jun 2025 16:26:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0DA823858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0DA823858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749140768; cv=none; b=XU3ymZdYZw31YCduYVukQ09MMlqlklu7FxqsdsYSQImAZ8+2HB1F3RjtBPyEa7ywghx0V4T7fSIE+J7eY1KYQ7SyFm9WtnnkCjSHHNSGmNonb1yPjnuMyIOAxmUzTcsdGPxgtSqf4JHu895o43fWQZrkwz01K0J16f7UdvA6jEg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749140768; c=relaxed/simple; bh=EViV/Pu4X8S/s4nIFkuENFzIWCKKqgkj/WW0xPqApkM=; h=Message-ID:Date:MIME-Version:Subject:From:To; b=YfPBqOn/fqQhlth3YyEl0TPz5ArGjg1RhrRYNj/J80VQ2570YWrtyREnD7AWZmPzs+KmvjGDsvzOmMJc8CZUqDYKf72pw05zuczjtl1ClXpl/DoSu4FtgPk1+Q1X6ZtdRE2ssxUgKSceyVnvybfoiidIWDDnmP4yppDxOmfuMWw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0DA823858D34 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-450cf0120cdso11386075e9.2 for ; Thu, 05 Jun 2025 09:26:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749140766; x=1749745566; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7kEQ1jKENk0XhAQXG3tEahp3BU5uSfoRWBSoJBHPu7c=; b=umEl3hKce5OvC7iynr4dOvbsDjmdctXMCtigDbLazY0HHNTFQ+9CNVSZWwG2pwix8w kuqrjezVbQP9gsi16DY/ZIiTMVcEY+635bo2S+TE1dWEPJ5kY4D726KiRB3lF/AOA/TI GH08SJ6psnK5rY0YOIDURJPQJ7W8bd+HM+9d4stH8So0ixzgPa6nPXR6DPaEkOOlMutN 6JlnynnfI4vFR2yTWbbnvnPy5YWm39NUtXEj2xDqVsKUvH2fufZC90dSpRXMv3FXZNbV upWhxuco44LesrUkuoOmQwJ8tv3F9hw6TIHcxKAiAwCJ80b69+Zr/I5z4qe6KUM7szfr Jvdw== X-Forwarded-Encrypted: i=1; AJvYcCUjvFPHjbd1dv6YUBtrGM2UIL1ysFAKWByVk7ztiayrWAzVXABhJFiDsxpr6yKy95JOWOGxFu/6nCHb1Q==@sourceware.org X-Gm-Message-State: AOJu0Yzg1SOmPTdDvQUne8/aFAw6kFM/4SaX0Dgv70b8857ffOJkL3gG hNwokUHxoLEhzvULiCwInwi9BOflD0GsiQ19/B9oFqKCERDH0BnvFkNltIvN7oid X-Gm-Gg: ASbGncvhszCkm+j7ojM0vR70YIThFCBIUQkEvlJPscg3kwvEsHd0I2Im7RGvUXUx6/L g5wFTYIa+NgbWj3Yhvd/o7EmP2pumVNV38kYIAx3TqabihwgFcxzPdSlonIngKYG2ViwFkDPRv+ HLAPEaLcJ/1qTCeO2U+ZkcOkYUvdclKYJywwS/lfBaERpAT2FWd/RWjlUXPeVuWibOAJxzGCH/o 9eXN998vXyJAKNn1qnRq2JEA75SzLH2xpVAIw60BMkqipxeyn2lkBKRaWHP0z5fMkOVJujE873B X7WyNOr3TE7cg01Z1LwKhSGfKodmFe0O4TYb1giySiSRIuEFDcursIdJs+yroe61iNKoRA/7d7A vO9w9qm7e2qKlRKB12Go= X-Google-Smtp-Source: AGHT+IGrkL1Dgg06DDrs1tOnrR+JsrbPAJmhzK7+pUA/4n03AekBofNyTr99LV2N6S4biB/3GW7X0A== X-Received: by 2002:a05:600c:1e08:b0:441:d438:505c with SMTP id 5b1f17b1804b1-451f0b54b6fmr72234365e9.32.1749140765612; Thu, 05 Jun 2025 09:26:05 -0700 (PDT) Received: from ?IPV6:2001:8a0:facf:2b00:451a:975e:a6cb:7552? ([2001:8a0:facf:2b00:451a:975e:a6cb:7552]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-451fb2206d1sm23036415e9.30.2025.06.05.09.26.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jun 2025 09:26:05 -0700 (PDT) Message-ID: Date: Thu, 5 Jun 2025 17:25:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/tdep] Don't call WaitForSingleObject with INFINITE arg From: Pedro Alves To: Tom de Vries , gdb-patches@sourceware.org References: <20250605150330.26246-1-tdevries@suse.de> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-06-05 17:15, Pedro Alves wrote: > On 2025-06-05 16:03, Tom de Vries wrote: >> Fix this by avoiding calling WaitForSingleObject with INFINITE argument. > > Approved-By: Pedro Alves > Actually, can you add a comment to the code, please, explaining why we're avoiding INFINITE? LGTM with that. :-) On 2025-06-05 16:03, Tom de Vries wrote: > while (true) > { > - DWORD r = WaitForSingleObject (handle, howlong); > + DWORD milliseconds = howlong == INFINITE ? 100 : howlong; > + DWORD r = WaitForSingleObject (handle, milliseconds); > + if (howlong == INFINITE && r == WAIT_TIMEOUT) > + continue; > if (r == WAIT_OBJECT_0) > return;