[ was: Re: [PATCH 1/2] AArch64 AAPCS: Empty structs have non zero size
in C++ ]

On 11-10-2019 01:49, Tom de Vries wrote:
> On 21-01-2019 16:52, Alan Hayward wrote:
> 
>> +       if { ( $lang == "c++"
>> +              && ( ( [regexp "struct_01_0(1|2|3)" $name match] && [regexp "^types-(td($|-)|tl(|l)(|-tf|-td|-tld)$)" $types match] )
>> +                   || ( $name == "struct_01_02" && $types == "types-tfc" )
>> +                   || ( $name == "struct_01_04" && [regexp "^types-(tf($|-)|ti(|-tf|-td|-tld)$)" $types match] )
>> +                   || ( $name == "struct_02_01" && [regexp "^types-tf-t(c|s|i)" $types match] ) ) ) } {
>> +           setup_xfail gdb/24104 "x86_64-*-linux*"
>> +       }
>>         gdb_test "p/d check_arg_${name} (ref_val_${name})" "= 1"
> 
> 
>> +           if { ($lang == "c++" && $name == "struct_02_01" && [regexp "^types-(tf-t(c|s|i)|t(c|s|i)-tf)" $types match] ) } {
>> +               setup_xfail gdb/24104 "x86_64-*-linux*"
>> +           }
>>             gdb_assert [string eq ${answer} ${refval}] ${test}
> 
> These should have been kfails, not xfails.

This patch fixes PR24104.

OK for trunk?

Thanks,
- Tom