From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62891 invoked by alias); 9 Oct 2017 21:14:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62882 invoked by uid 89); 9 Oct 2017 21:14:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Oct 2017 21:14:55 +0000 Received: from [10.0.0.11] (cable-192.222.251.162.electronicbox.net [192.222.251.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C903F1E517; Mon, 9 Oct 2017 17:14:53 -0400 (EDT) Subject: Re: [RFC][08/19] Target FP: Use target format throughout expression parsing To: Joel Brobecker , Ulrich Weigand Cc: gdb-patches@sourceware.org References: <20170905182110.3ED3BD8086F@oc3748833570.ibm.com> <20171009181215.tx5pxfnpuxt7ikcy@adacore.com> From: Simon Marchi Message-ID: Date: Mon, 09 Oct 2017 21:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171009181215.tx5pxfnpuxt7ikcy@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00238.txt.bz2 On 2017-10-09 02:12 PM, Joel Brobecker wrote: > One C++ thing I did notice but forgot to report... > >> +floatformat_from_string (const struct floatformat *fmt, gdb_byte *out, >> + std::string in) > > Again, to be double-checked, but I think you want to pass the argument > by reference in this case. Otherwise, you may end up having an overhead > with might not be necessary due to the creation of a copy of the string > being passed as argument here. > Indeed, it's good practice to pass constant strings (or other objects) as const references (const std::string &in). Simon