Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 2/2] Teach GDB that wchar_t is a built-in type in C++ mode
Date: Fri, 31 Mar 2017 12:38:00 -0000	[thread overview]
Message-ID: <e95682ba-107b-f1af-7b56-468411b62f9b@redhat.com> (raw)
In-Reply-To: <837f35636f.fsf@gnu.org>

On 03/31/2017 01:28 PM, Eli Zaretskii wrote:
>> From: Pedro Alves <palves@redhat.com>
>> Date: Fri, 31 Mar 2017 12:03:15 +0100
>>
>> New in v2:
>>
>>   - Go through all ports and override wchar_t size/sign appropriately.
> 
> I think go32 needs the same treatment as Windows, since its system
> headers say
> 
>   typedef unsigned short wchar_t;
> 

Ah, yes, missed that one.  Consider this added to
i386-tdep.c:i386_go32_init_abi:

  set_gdbarch_wchar_bit (gdbarch, 16);
  set_gdbarch_wchar_signed (gdbarch, 0);

Thanks,
Pedro Alves


  reply	other threads:[~2017-03-31 12:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-31 11:03 [PATCH v2 0/2] PR c++/21323: char16_t/char32_t/wchar_t built-in C++ types Pedro Alves
2017-03-31 11:03 ` [PATCH v2 2/2] Teach GDB that wchar_t is a built-in type in C++ mode Pedro Alves
2017-03-31 12:28   ` Eli Zaretskii
2017-03-31 12:38     ` Pedro Alves [this message]
2017-03-31 13:00       ` Eli Zaretskii
2017-03-31 11:03 ` [PATCH v2 1/2] Fix PR c++/21323: GDB thinks char16_t and char32_t are signed in C++ Pedro Alves
2017-04-12 13:10 ` [PATCH v2 0/2] PR c++/21323: char16_t/char32_t/wchar_t built-in C++ types Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e95682ba-107b-f1af-7b56-468411b62f9b@redhat.com \
    --to=palves@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox