From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id TiN5IcJlvmpW4SMAWB0awg (envelope-from ) for ; Thu, 01 Oct 2026 09:53:06 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=DrvStSGk; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 733AA1E051; Thu, 01 Oct 2026 09:53:06 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DB2091E01F for ; Thu, 01 Oct 2026 09:53:05 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6DE324BB3B93 for ; Thu, 1 Oct 2026 13:53:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6DE324BB3B93 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=DrvStSGk Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id B152D4BB3B93 for ; Thu, 1 Oct 2026 13:52:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B152D4BB3B93 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B152D4BB3B93 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790862760; cv=none; b=ZAPQVPtVF9KhXEyikM39mbekQuFYTNNa6l1pcTg4gey6trH/3zCWG0nUr93qkgRWjdDs79YEXfVkaK6fsRi0HIy+X+s8pWdRrNCqNfH5rT4DSMLqdLxJtfkGao2xszKAnwL3dV7FCWZ21wy7/BRpzvkEHM17nG3Xxdssq+O5DjY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790862760; c=relaxed/simple; bh=V8ycvPc4lcXOLWngYeixbkc7F8eTDB/WRbJybOQJ980=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=g75iXMZXzosDVJyuWWLjckf/Cf15W0fnO821acSP1tsFhiJorRsP9TjvJQNSEp/Pc+As3UNzR9hPcUAXCsuwVYcja3m5iTMmVnsiPRdA1Nr55zDavQTAEszlqKBsfYPvU/jZMQtqzYdh6zXrqzZzzEIAD4OgvNcrf/IPP3pVCC8= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=DrvStSGk DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B152D4BB3B93 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 691DqWPJ112726 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 1 Oct 2026 09:52:37 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 691DqWPJ112726 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1790862758; bh=enz5NQLF/GHbhvZQXJZxFYw8AHqZS0h60XU2Po21XUI=; h=Date:Subject:To:From:In-Reply-To:From; b=DrvStSGkXvLC2SvpKj5kf0kFA7sY1/aYTDTEMliQpSl70+zFqk+J6A168CXH42sYI tn9QB4WKx0tt4c5ulm64Zu1XPojtnfossCuCOyEqXU33a/FjZoEOUhMHH7g4YQpIgW yLVY0emfeaFHWh5hPaeOB+I99nlcub2VNR15qIAu2tP/5StErIRnFB/1DYs4QnBl28 GEwDLdLGfn0VoIn2LwLZeV9IowT0huZStrGtiugPudbf5Sp43PjkdQg344uRkgvKbr Zs/vdzjUnWEZv6AUP4vgKFhMSOcA3eCdTtNyNjCg2yIGqN2Z8m701s96UO233I7cEv b5Wy6eFAtzm4Q== Received: by simark.ca (Postfix) id 7C8661E01F; Thu, 01 Oct 2026 09:52:31 -0400 (EDT) Message-ID: Date: Thu, 1 Oct 2026 09:52:30 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/11] gdb: rename some preg/treg variables To: Andrew Burgess , gdb-patches@sourceware.org References: <20260929194119.155169-1-simon.marchi@efficios.com> <20261001020952.698419-3-simon.marchi@polymtl.ca> <87a4oxzidj.fsf@redhat.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87a4oxzidj.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 1 Oct 2026 13:52:32 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/1/26 8:59 AM, Andrew Burgess wrote: > simon.marchi@polymtl.ca writes: > >> From: Simon Marchi >> >> global_symbol_searcher and some code around that use "preg" and "treg" as >> variable, parameter or field names. Rename to the clearer "name_regex" and >> "type_regex". >> >> I guess that "preg" came from the parameter name of regcomp/regexec, and >> treg was derived from that. > > There are 5 lines that you touch where NULL could be changed to nullptr. > > I thought we generally made that update whenever we touched a line, but > I'll leave it up to you. Yes but I don't always remember to do it, done now. > Approved-By: Andrew Burgess Thanks, Simon