From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4128 invoked by alias); 29 Nov 2016 15:07:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4112 invoked by uid 89); 29 Nov 2016 15:07:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:2339, GDBserver, letter X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Nov 2016 15:07:00 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cBjzm-0002SL-Bo from Luis_Gustavo@mentor.com ; Tue, 29 Nov 2016 07:06:58 -0800 Received: from [172.30.5.15] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Tue, 29 Nov 2016 07:06:55 -0800 Reply-To: Luis Machado Subject: Re: [PATCH v2 4/8] Fix test names starting with uppercase using gdb_test_multiple References: <1480107244-1484-1-git-send-email-lgustavo@codesourcery.com> <1480107244-1484-5-git-send-email-lgustavo@codesourcery.com> <20161127170947.32vzeqciax5v275h@localhost> <20161129144851.GF22209@E107787-LIN> To: Yao Qi CC: From: Luis Machado Message-ID: Date: Tue, 29 Nov 2016 15:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161129144851.GF22209@E107787-LIN> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-04.mgc.mentorg.com (147.34.90.204) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00946.txt.bz2 On 11/29/2016 08:48 AM, Yao Qi wrote: > On Mon, Nov 28, 2016 at 10:06:28AM -0600, Luis Machado wrote: >> On 11/27/2016 11:09 AM, Yao Qi wrote: >>> On Fri, Nov 25, 2016 at 02:54:00PM -0600, Luis Machado wrote: >>>> This fixes offender testcases that have test names starting with uppercase >>>> when using gdb_test_multiple in a single-line construct. >>>> >>>> gdb/testsuite/ChangeLog >>>> 2016-11-25 Luis Machado >>>> >>>> Fix test names starting with uppercase throughout the files. >>>> >>>> * gdb/testsuite/gdb.arch/i386-bp_permanent.exp >>>> * gdb/testsuite/gdb.arch/i386-gnu-cfi.exp >>>> * gdb/testsuite/gdb.base/disasm-end-cu.exp >>>> * gdb/testsuite/gdb.base/macscp.exp >>>> * gdb/testsuite/gdb.base/pending.exp >>>> * gdb/testsuite/gdb.base/watch_thread_num.exp >>>> * gdb/testsuite/gdb.cp/exception.exp >>>> * gdb/testsuite/gdb.cp/gdb2495.exp >>>> * gdb/testsuite/gdb.cp/local.exp >>>> * gdb/testsuite/gdb.python/py-evsignal.exp >>>> * gdb/testsuite/gdb.python/python.exp >>>> * gdb/testsuite/gdb.trace/tracecmd.exp >>> >>> Drop "gdb/testsuite/". Patch is good to me, but I think we need to >>> enforce a rule in "proc gdb_test_multiple" that test message should >>> start with a lower case letter, emit an ERROR if it starts with >>> uppercase. >>> >> >> Do you mean just for gdb_test_multiple? > > Yes, > Why just that one? Shouldn't we attempt to enforce this for all the other proc's, so gdb_test, gdb_test_multiple, gdb_test_no_output and mi_gdb_test? >> >> It can be tricky, since one is still free to start the sentences >> with something like "ARM ..." or some other technology name. So >> unfortunately we can't be too strict. I wish we could. > > Do we have some many technology names? We have a white list of these > technology names which can be capitalized in test message. > It is certainly possible, but do we want to add one more layer of maintenance? We could enforce a rule from now on to require test names to always start with lowercase or to even be all lowercase. I don't think we're coherent with our use of lower/uppercase anyway. For example, GDBserver gets called gdbserver in gdbserver's own help text and the testsuite is (less so now with this series) a mixed bag. I'm open to ideas.