From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 9RP9JiBqR2dmBAIAWB0awg (envelope-from ) for ; Wed, 27 Nov 2024 13:51:12 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=AszMnyLu; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8036E1E097; Wed, 27 Nov 2024 13:51:12 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0AC411E05C for ; Wed, 27 Nov 2024 13:51:10 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 893243858D34 for ; Wed, 27 Nov 2024 18:51:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 893243858D34 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=AszMnyLu Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 2418F3858D34 for ; Wed, 27 Nov 2024 18:50:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2418F3858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2418F3858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732733432; cv=none; b=nJfkiD7R1UnZ4q0ToMxCsUW1Bdl+yAbsM0togke9DI/gqndAATiWAE/SIA5B09Ox8YMBXIsSIV+BcbwQwuRG9bMOFY7Y00Q0YIQYFGVQuNPAcm2KyhmhvuJEjLmNciVMdNI9VYRqOkvQZF/u1cTPFxdefLqq8zVbqxZLb4eTQ2s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732733432; c=relaxed/simple; bh=5b53ywZI93QqBl6Zug9bmTz3E0ejT/1HydUpTUX7mNg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=aC25QkbKqYWUzEF/bkydeBy/twMPahcLCAEQ2R2z5UaV8PVfzutxEBhHpnUzkKQrkzOqkX1Uu1683H/2OrHX35tYa+f82FdXEI760e9qZzd+M5m7G8Ajh+ryPj5fpLSBDyJ/S+zla5+J5aM8h1fikJnIL1QscOOGnYPOA3y5Ytw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2418F3858D34 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732733431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nIS49122odA6E6PmNK9EF3IGU1y5kwOXfXff81AlquQ=; b=AszMnyLu+zd9a1qhfh7OlyYlh8vdmMpjsdVP817Fwyc30MR3dtfYvtsDI7nX8ABTHFZLgS 83Jl5dF7GAH2+4X/rZXzM9r1gW9aBzhm+kpFadCDMLx4eVRJQWdrflmkUCaSJfCCBFYJlD 4TsqBv+cGKtxMqBe9pKL1Tq9J2XMYqU= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-214-_piYaxowNYKySBSqfS9ccg-1; Wed, 27 Nov 2024 13:50:30 -0500 X-MC-Unique: _piYaxowNYKySBSqfS9ccg-1 X-Mimecast-MFC-AGG-ID: _piYaxowNYKySBSqfS9ccg Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6d4030920f2so1158246d6.1 for ; Wed, 27 Nov 2024 10:50:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732733430; x=1733338230; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nIS49122odA6E6PmNK9EF3IGU1y5kwOXfXff81AlquQ=; b=b+XutuqRPTnit5mHhrS1Jt1KvTjQXCH3dMaRBPztkd0SklV22knbojRR+zJ97pQxGe XnM+MmBgU1GUDl8x2aHjrVhHNfdXYCD70qaS6GD9502fDEMaSqqqukp+jnMTlVEKJ+ws C2x++XvOBMXCaeb+Y+8CkOrMlAsE0X7AOMcliaetsNwgxqE3U/AnbOtts44GzYkiud2n IPHFi/cg40VStnvasmWt4LpQV88kGvAwZ7gqgj+S/vjeDpLYDxZt9n7JyPmbJRZckwR0 SGk3yfVrvik6VN/ap27iFWQxHawy7EqUZtfeVo8B53XvQT8kPZqhUjt+uG5WBOKLSiX1 ePOw== X-Gm-Message-State: AOJu0YxD7i6jvyBppCqVVMW3TnLa0fZEMp+tQyPDW3mryeqocanzpbFG 5FV1rwciaRWDqPJCaStbCe/3WQHrjrJrBj4oxm0u0vdkYRdxpeihJcVre+AneOUnYw73X2Yo0++ WpR/n1n+h7MZ+f9OHztqvlFX80tnzkuYpIf3k3nVaVSS1k+mK1eJKruJWFno= X-Gm-Gg: ASbGncvAxKUJ+Kysz4JX6C1o2+CcJxnQA4iw0SmvHXOTcLkaY1JQwFzj0XUiIq08RSE IwJ2GMS6A7ArD0mMtjjvwi2jTfWOjrOlAVtNsXPDoOzOMubJf0JdZ97UaznKpc81KxONffsT/G+ Ctb7xZh63fsIsU9e6UB7aYlNbV1G/0cZ5VG7/FX+Ow7H0GYOGQrFwYReYNuBJK+58Lykbw4mDWX KxDfLxYfCqWdW8Tw/tgK8yp8JQnfMSeF2xIjSgy9OhGty1ViBhp3koLx/J24w== X-Received: by 2002:a05:6214:5184:b0:6d4:142d:8119 with SMTP id 6a1803df08f44-6d864db14f2mr38536596d6.42.1732733429965; Wed, 27 Nov 2024 10:50:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IF/XMvt0w2PFmdFKr4o4ildx12GbL7wJpUQtAuHe/1EH0kAtgepSTvvhroeyrJorKKKts30Mg== X-Received: by 2002:a05:6214:5184:b0:6d4:142d:8119 with SMTP id 6a1803df08f44-6d864db14f2mr38536486d6.42.1732733429674; Wed, 27 Nov 2024 10:50:29 -0800 (PST) Received: from ?IPV6:2804:14d:8084:92c5::1000? ([2804:14d:8084:92c5::1000]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d451a9a9edsm67832756d6.53.2024.11.27.10.50.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Nov 2024 10:50:29 -0800 (PST) Message-ID: Date: Wed, 27 Nov 2024 15:50:27 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: skip gdb.threads/omp-par-scope.exp with clang To: Kevin Buettner Cc: gdb-patches@sourceware.org References: <20241125184225.1021664-1-guinevere@redhat.com> <20241127111402.048359b9@f40-zbm-amd> From: Guinevere Larsen In-Reply-To: <20241127111402.048359b9@f40-zbm-amd> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SKNZ9aJrect-YKBfJd1-7THFsCjEhyRBlP7TtX6TYrU_1732733430 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 11/27/24 3:14 PM, Kevin Buettner wrote: > On Mon, 25 Nov 2024 15:42:25 -0300 > Guinevere Larsen wrote: > >> Since 2020 it has been reported to clang[1] that the debug information >> around OpenMP is insufficient. The OpenMP section is not declared >> within the correct scope, and instead clang marks as if the section was >> a function in the global scope. This causes several failures in the >> test gdb.threads/omp-par-scope.exp when using clang to test GDB. >> >> Since this isn't a true failure of GDB, and there is little expectation >> that clang will be able to fix this soon, this commit disables the >> aforementioned test when clang is being used. >> >> [1] https://github.com/llvm/llvm-project/issues/44236 > I thought at first that it might make sense to XFAIL the problematic > tests. But after running it for myself, I see that clang has so many > problems that I now agree that it makes sense to disable the test > entirely (for clang). > > One nit though... > >> +if { [test_compiler_info "clang*"] } { >> + # Clang doesn't add OpenMP information in the correct scope, >> + # so all relevant tests here will fail. See here for more info: >> + # https://github.com/llvm/llvm-project/issues/44236 >> + unsupported "Clang doesn't add required info for the test" > Could you change the message to: > > "Clang doesn't provided the required debuginfo for this test" > > ? > >> + return >> +} >> + > With that nit fixed... > > Approved-by: Kevin Buettner > pushed with the nit fixed! Thanks for the quick review -- Cheers, Guinevere Larsen She/Her/Hers