From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id fwuXF9NEqWj7NQoAWB0awg (envelope-from ) for ; Sat, 23 Aug 2025 00:34:27 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=T/bgbYNv; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Qk4HOZAe; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=T/bgbYNv; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Qk4HOZAe; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 501B91E048; Sat, 23 Aug 2025 00:34:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 90D9B1E043 for ; Sat, 23 Aug 2025 00:34:26 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1FB633858C42 for ; Sat, 23 Aug 2025 04:34:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1FB633858C42 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=T/bgbYNv; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Qk4HOZAe; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=T/bgbYNv; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Qk4HOZAe Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 21A723858D1E for ; Sat, 23 Aug 2025 04:33:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 21A723858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 21A723858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755923617; cv=none; b=qqEexAq8u16weISaYLbTKi+EzOSOpfRuMoV/PmFjSa5nzPYWt1cLbuwG6R2gU2uUqbMJcF+g91US6GNQNNpagNK8M+0Qd3lUVDSPHYB+/69lFOqPNHi2CZuItGo4qi6lAK9GwwfUZJRPEMdQXkwc+Hsszt0fEGVmA8+LYk5DZ3c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755923617; c=relaxed/simple; bh=MUdIZYl47j4uekxfJzcKYDF33hovvveQcAG1vV31zoI=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=gGOSyx77rRGZl7T3zaRBP7YuGbmtrf3B3rrYtw8T8fgSdutc74kJPN4TAmIyxi5C/sb6d2r6mmTgJlbx+j6FuzqbMe33MaL1GjehIyL1dmL2Y13vrBWC6XqKau+t80qwD8jt4w6snOK/5cJsaFGlWp8pJLagWLmW+EI4XywU+jI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 21A723858D1E Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 51B7321979; Sat, 23 Aug 2025 04:33:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1755923615; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1f+j0xXyNWD7hz8dSzSlL/f9qz5nBkY+WhvXF9Y4eys=; b=T/bgbYNvKAq9FunM4xqv58ZJoRg0pLbO2EniMWYShOVzaQwsF/Yy8nUMbk+XlGYtXMDSvS WiXWR0stfxaMKv0EwkqpTZTUsHD0RGOtuA/nEXh1yQDOzCinZNWHv3Vs/R6DTJqAPq0GH6 o2qyobpE6TWl+C/xVOzjcBqJR5h1br0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1755923615; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1f+j0xXyNWD7hz8dSzSlL/f9qz5nBkY+WhvXF9Y4eys=; b=Qk4HOZAegWbpzdTG69jdwMMobeooXsN+1wYQE7V26EaaNL41gUccJTtS1gUDLwwCE9s5VU kHeQiMam7lqidmAA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1755923615; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1f+j0xXyNWD7hz8dSzSlL/f9qz5nBkY+WhvXF9Y4eys=; b=T/bgbYNvKAq9FunM4xqv58ZJoRg0pLbO2EniMWYShOVzaQwsF/Yy8nUMbk+XlGYtXMDSvS WiXWR0stfxaMKv0EwkqpTZTUsHD0RGOtuA/nEXh1yQDOzCinZNWHv3Vs/R6DTJqAPq0GH6 o2qyobpE6TWl+C/xVOzjcBqJR5h1br0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1755923615; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1f+j0xXyNWD7hz8dSzSlL/f9qz5nBkY+WhvXF9Y4eys=; b=Qk4HOZAegWbpzdTG69jdwMMobeooXsN+1wYQE7V26EaaNL41gUccJTtS1gUDLwwCE9s5VU kHeQiMam7lqidmAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3683413867; Sat, 23 Aug 2025 04:33:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id S5NlC59EqWi+YwAAD6G6ig (envelope-from ); Sat, 23 Aug 2025 04:33:35 +0000 Message-ID: Date: Sat, 23 Aug 2025 06:33:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/5] [gdb/symtab] Improve invalid range check in create_addrmap_from_gdb_index To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250821133114.24091-1-tdevries@suse.de> <20250821133114.24091-5-tdevries@suse.de> <875xefkx1i.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <875xefkx1i.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/22/25 20:53, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> + struct obj_section *lo_sect = find_pc_section (relocated_lo); > > find_pc_section searches all the objfiles but it seems better to > restrict the search to just this objfile (or related non-debug objfile). > > Using the BFD's sections would mean not having to deal with the runtime > offsets as well. Hi, Agreed. My rationale for using this approach was to reuse code as much as possible, but as mentioned here ( https://sourceware.org/pipermail/gdb-patches/2025-August/220136.html ), it made things more complicated, and in v3 I'm no longer using find_pc_section. Thanks, - Tom