From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69295 invoked by alias); 13 Jul 2018 21:49:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69262 invoked by uid 89); 13 Jul 2018 21:49:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:944 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Jul 2018 21:49:38 +0000 Received: by simark.ca (Postfix, from userid 112) id 244C11EF28; Fri, 13 Jul 2018 17:49:36 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531518576; bh=H15/ezQQE1n2Kvyc9K5czlS8MFigEHJNlSc3E2ZzzTg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=b4+e02D1VJZAmbNlD3Q78zOaAWMvbBdiUhCRwMZK0V7TFEbvIdNQJncA8+z6v+6AK iU5OMywM5NQG2hgX7hV0UCjlZnT/U8Wxke24qVm9JiGPnb9r0Rexkx6zGlMc0Rso16 599E2z3R2IioRjKR27Lu+O99UJt0XF64WF232LmY= Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 5DB111E48F; Fri, 13 Jul 2018 17:49:35 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531518575; bh=H15/ezQQE1n2Kvyc9K5czlS8MFigEHJNlSc3E2ZzzTg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qEd1+65PMLh2xpn5uRT1buWrZubQCFQkcEVJxBqRwVXIQz1e/IQZsmz8CJaDCCbN1 37Pk9X1a5NHN/GtnDvHHtpj4hAckO+JkOa94gzslMydx686gUKUe30cQM9dwc3tuWn 1xVJAZWsO7VUAJDuVoDc2NIu7SEgu+jIgVYRztKE= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 13 Jul 2018 21:49:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 10/13] Remove unused declaration from value.c In-Reply-To: <877elyc11j.fsf@tromey.com> References: <20180712205208.32646-1-tom@tromey.com> <20180712205208.32646-11-tom@tromey.com> <97a938d0-3cf4-dc2a-b572-6e55b824cf98@simark.ca> <877elyc11j.fsf@tromey.com> Message-ID: X-Sender: simark@simark.ca User-Agent: Roundcube Webmail/1.3.6 X-SW-Source: 2018-07/txt/msg00433.txt.bz2 On 2018-07-13 16:51, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> On 2018-07-12 04:52 PM, Tom Tromey wrote: >>> This removes an unused declaration from value_fetch_lazy_bitfield, >>> but >>> leaves the call to check_typedef, because it may be called for >>> effect. > > Simon> Do you know for sure this is necessary (e.g. without this, some > test fails), > Simon> or you are just being cautious? > > Just being cautious. It's entirely possible that this isn't needed. > Maybe removing it is correct in that nothing in the function appears to > need it, and if it causes a bug then that means that some other spot > ought to have called check_typedef. > > Tom Then my opinion would be to check if removing it causes any test failure. If not, I'd remove it (in its own commit such as this patch is good, so it's easy to bisect if needed). Simon