Re: [PATCH] nat/fork-inferior: include linux-ptrace.h

Joel Brobecker
2018-06-27T16:29:39Z

> > > fork-inferior.c is also included in native builds for BSDs, AIX,
> > > Solaris
> > > and Darwin (see gdb/configure.nat). I am a bit concerned that
> > > linux-ptrace.h could use some Linux-specific things, and thus would
> > > break the other builds. However, I built-tested on FreeBSD and it
> > > seems
> > > fine. Worst case, we can probably wrap this include in "#ifdef
> > > __linux__" if that becomes a problem.
> >
> > Or better, this horrible mess of __UCLIBC__ and HAS_NOMMU macros should
> > be replaced by a proper autoconf check testing for the availability of
> > fork().
>
> Agreed, and I think Pedro will agree too (unless you can think of a simpler
> solution that doesn't involve autoconf?).

We already autoconf for "fork" (see HAVE_FORK in config.in).
Does that help?

--
Joel