From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73083 invoked by alias); 5 Apr 2017 12:59:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71066 invoked by uid 89); 5 Apr 2017 12:59:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy=tiny X-HELO: mail-wr0-f182.google.com Received: from mail-wr0-f182.google.com (HELO mail-wr0-f182.google.com) (209.85.128.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Apr 2017 12:59:18 +0000 Received: by mail-wr0-f182.google.com with SMTP id k6so13452151wre.2 for ; Wed, 05 Apr 2017 05:59:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=P6QpKpTuEywKBlzSWDeNOwOjpavg1JtdrDXevbVZlX0=; b=MrmHCeeAbEluwHUN6QxfuEcKUccSV4LfoKX8ojr0jNpbHEvJG6DVXjoBB8YILNj7KZ j+1kfEBdUpgUx5SwK51cKSCBsQjtqGSVmshJKCgkE9/0wvjJCCzge4F9cghYmvXFV8Hr rMmR+X7Ay4WUT145O9dHx6QpgMEh/25irdh1LD9JXWdIL8rid4wX7d99Sz3Yo6fdV4wy sFwvY5PS5dQZAMzml6zeYuYoqzBRKXKaM0oQuFqPIlI5CQz5huatysnmPVxItrY7vmvR oXbOJV430hLU4wlMK4oEZB7suSLxtSGlpt6N3q7sBbonATQ7yqcHM6+hKj56z0MKD3xn COuw== X-Gm-Message-State: AFeK/H3yUFWBOzI6uGPyrGOiRcsr4ErR1Ld+YNy9HlQyuHxrNj5amWZ4SliibmsVOg2JT0Y5 X-Received: by 10.223.149.99 with SMTP id 90mr24848907wrs.7.1491397157350; Wed, 05 Apr 2017 05:59:17 -0700 (PDT) Received: from [192.168.0.100] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id h187sm22363585wma.32.2017.04.05.05.59.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Apr 2017 05:59:16 -0700 (PDT) Subject: Re: [PATCH 17/18] -Wwrite-strings: The Rest To: John Baldwin , gdb-patches@sourceware.org References: <1491326751-16180-1-git-send-email-palves@redhat.com> <1491326751-16180-18-git-send-email-palves@redhat.com> <6118858.lO2ajWnfox@ralph.baldwin.cx> From: Pedro Alves Message-ID: Date: Wed, 05 Apr 2017 12:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <6118858.lO2ajWnfox@ralph.baldwin.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00097.txt.bz2 On 04/04/2017 07:22 PM, John Baldwin wrote: > On Tuesday, April 04, 2017 06:25:50 PM Pedro Alves wrote: >> This is the remainder boring constification that all looks more of less >> borderline obvious IMO. >> >> gdb/ChangeLog: >> yyyy-mm-dd Pedro Alves >> >> * fbsd-tdep.c (fbsd_core_pid_to_str): Constify. > > Tiny nit: this isn't actually changed in this patchset (was going to quickly > eyeball it). Whooops, sorry about that. Fixed locally. > Perhaps the changelog is stale from you breaking the > pid_to_str target method out into its own patch? That's exactly what happened. Thanks for taking a look! -- Pedro Alves