From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4V94MhZba2CJNQAAWB0awg (envelope-from ) for ; Mon, 05 Apr 2021 14:46:46 -0400 Received: by simark.ca (Postfix, from userid 112) id C3DC91E789; Mon, 5 Apr 2021 14:46:46 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E4A671E01F for ; Mon, 5 Apr 2021 14:46:45 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 277D13858031; Mon, 5 Apr 2021 18:46:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 277D13858031 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1617648405; bh=Jud9vorZ6e4wpQgCX85umrFcg6YIMxe75JvRYS3S5Rg=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=twhFc99l1WQyxWjPI0HGh9fvWjj1H+epkr/Dccmq3iUffMT/uF7qFsjn5StTEFmle 6qB+CLAbwdXblCSVnbrxJV9TiVwuFAzjxwp7W521CL0+mEb2LmDagp8l+VYlJAODZz tTmiTVqCscS0jJiMyU/Dm+lfJsungE8iMzWI23u8= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 95EF23858031 for ; Mon, 5 Apr 2021 18:46:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 95EF23858031 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 135IkcjD024845 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 5 Apr 2021 14:46:42 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 135IkcjD024845 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 345B81E01F for ; Mon, 5 Apr 2021 14:46:38 -0400 (EDT) Subject: Re: [PATCH] sim/m32c: fix memory leaks in opc2c To: gdb-patches@sourceware.org References: <20210405145856.3925296-1-simon.marchi@polymtl.ca> Message-ID: Date: Mon, 5 Apr 2021 14:46:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 5 Apr 2021 18:46:38 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-04-05 12:23 p.m., Mike Frysinger wrote:> On 05 Apr 2021 10:58, Simon Marchi via Gdb-patches wrote: >> Fix the leak in dump_lines by free-ing the elements of varnames. > > i dislike stuffing a bunch of free's at the end of a program's lifetime just > to satisfy a tool that is not normally used. which isn't to say LSAN isn't > useful, just that i think we should do better. Why though? Because it adds execution time where not necessary? > in other codebases, i've done things like: > #ifdef __SANITIZE_ADDRESS__ > # define ENABLE_CLEANUP_ONEXIT 1 > #else > # define ENABLE_CLEANUP_ONEXIT 0 > #endif > > then this could be written: > > if (ENABLE_CLEANUP_ONEXIT) { > for (i = 0; i < vn; i++) > free (varnames[i]); > } > > wdyt ? feel free to bikeshed the name. not sure if there's prior art in > the tree currently. I find this complexity a bit unnecessary, versus just free-ing the stuff. But I don't really mind, we can do as you like, I just want to my build to be fixed! Note that the igen tool doesn't free anything, so it's next on the list of things that break the -fsanizite=address build. I started to update it to free things, it's a bit tedious but it should be do-able. Another option would be to change the Makefile to call igen with the ASAN_OPTIONS=detect_leaks=0 environment variable. Simon