From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MCBWNqPfs2FJZwAAWB0awg (envelope-from ) for ; Fri, 10 Dec 2021 18:15:47 -0500 Received: by simark.ca (Postfix, from userid 112) id DC8981F0D0; Fri, 10 Dec 2021 18:15:47 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, NICE_REPLY_A autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 65CF71EDEE for ; Fri, 10 Dec 2021 18:15:47 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0DA0E385781D for ; Fri, 10 Dec 2021 23:15:47 +0000 (GMT) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by sourceware.org (Postfix) with ESMTPS id 6E9FC3857C6E for ; Fri, 10 Dec 2021 23:15:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6E9FC3857C6E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f41.google.com with SMTP id j3so17480324wrp.1 for ; Fri, 10 Dec 2021 15:15:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=eWtemzRpIKG8+mxyfEBJAO4l9lUnjKOgNf8U1meDgDU=; b=gNuX5+yr2L10lVcW6iixDujyJAIlXMlpZsYbPlQzk4yU1SG5dxwWEN/Mkb3X3c8WYL JV/eTn7xv4Mz9+8QxlQ/qhRj3cNxDyxGoMvjx51a4DGcsLWDmeNPOwumbF1wdQPFp/kl UDxd+ClZe0Zyx1xOl61eATC/uZgwqqPQar36B4TCgmt5+6AvR9/qm8PL9W0JEtRtVOgH GcjqhAhK7fO0ESsD05M4vOtUj7a3hY6zGrfYBwX7RXMjzQTnoXqz7+PzXiFXywSfDL/Q uXCdxo5NLaPe4W6swEFZYDVU/Flgl2E/3Dpq9Yf6Orrj4up/zqYg089fuv4o3mXRAeNU W7fg== X-Gm-Message-State: AOAM530GcKcldb324aC4ENKD2ubxHHKvNuJelKseOzJNpAu8R/a98wts 7/6bRYpYqOjf9ZGqDBc79nAE7gw8LDo= X-Google-Smtp-Source: ABdhPJyBjVuQWr24nSxiXKkjfF7lUiMN9BRLMCgiw9dL+tGcrFqjIFjnSyp5HJKhH8ZRRcgzIMxf6Q== X-Received: by 2002:a5d:49c3:: with SMTP id t3mr17316646wrs.207.1639178134467; Fri, 10 Dec 2021 15:15:34 -0800 (PST) Received: from ?IPV6:2001:8a0:f912:1a00:d3db:ac91:4b9e:1449? ([2001:8a0:f912:1a00:d3db:ac91:4b9e:1449]) by smtp.gmail.com with ESMTPSA id w2sm3592150wrn.67.2021.12.10.15.15.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Dec 2021 15:15:33 -0800 (PST) Message-ID: Date: Fri, 10 Dec 2021 23:15:32 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH 16/29] gdb/testsuite: Remove duplicates from gdb.base/ui-redirect.exp Content-Language: en-US To: Lancelot SIX , gdb-patches@sourceware.org References: <20211121175636.779325-1-lsix@lancelotsix.com> <20211121175636.779325-17-lsix@lancelotsix.com> From: Pedro Alves In-Reply-To: <20211121175636.779325-17-lsix@lancelotsix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-11-21 17:56, Lancelot SIX via Gdb-patches wrote: > When running the testsuite, I have: > > Running .../gdb/testsuite/gdb.base/ui-redirect.exp ... > DUPLICATE: gdb.base/ui-redirect.exp: redirect while already logging: set logging redirect off > > Fix by moving the first 'set logging redirect off' at the end of the "at the end" -> "to the end". "at" changes meaning completely, confusing. OK with that change. > previous [with_test_prefix] test block. The statement's purpose is to > clean the on flag set in this previous block, so moving it there makes > sense and does not change the sequence of commands in the test file.. > > Tested on x86_64-linux. > --- > gdb/testsuite/gdb.base/ui-redirect.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.base/ui-redirect.exp b/gdb/testsuite/gdb.base/ui-redirect.exp > index 363c563a5a1..6ed9c49c427 100644 > --- a/gdb/testsuite/gdb.base/ui-redirect.exp > +++ b/gdb/testsuite/gdb.base/ui-redirect.exp > @@ -95,10 +95,10 @@ with_test_prefix "redirect" { > gdb_test_no_output "userdefined" > gdb_test "set logging off" "Done logging to /dev/null\\." > gdb_test "help" "List of classes of commands:.*" > + gdb_test_no_output "set logging redirect off" > } > > with_test_prefix "redirect while already logging" { > - gdb_test_no_output "set logging redirect off" > gdb_test "set logging on" \ > "Copying output to /dev/null.*Copying debug output to /dev/null\\." > gdb_test "set logging redirect on" \ >