From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3UswMcowEGAkLAAAWB0awg (envelope-from ) for ; Tue, 26 Jan 2021 10:10:02 -0500 Received: by simark.ca (Postfix, from userid 112) id BB5DA1EF80; Tue, 26 Jan 2021 10:10:02 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ABAC51E945 for ; Tue, 26 Jan 2021 10:10:01 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F417F3846401; Tue, 26 Jan 2021 15:10:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F417F3846401 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1611673801; bh=CvMGK/U0dPcCb+vKBpVRlwIG4+g3YnhwPC2vPk2vST4=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=hzXc2DWvB4JCbxKZpQ2dTN9fhkYk1b+4pt9tshlkejn9fPwEPoDp0nyM8blASQqUr UATx7L0JeW8IunDiJ+T83396DGsW7izUgakHlGjq386ApjnhQ32qXtLJH+u7Xck7zA qpkpalM5g+JJ7SEYU6UemelCkuH+q5CGt/t9tQHY= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 773193846401 for ; Tue, 26 Jan 2021 15:09:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 773193846401 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 10QF9pF0000400 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Jan 2021 10:09:56 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 10QF9pF0000400 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C07991E945; Tue, 26 Jan 2021 10:09:51 -0500 (EST) Subject: Re: [PATCHv2 1/3] gdb: refactor the initialization file lookup code To: Andrew Burgess , gdb-patches@sourceware.org References: Message-ID: Date: Tue, 26 Jan 2021 10:09:51 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 26 Jan 2021 15:09:51 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-01-26 4:48 a.m., Andrew Burgess wrote: > +static void > +get_init_files (std::vector *system_gdbinit, > + std::string *home_gdbinit, > + std::string *local_gdbinit) > +{ > + /* Cache the file lookup object so we only actually search for the files > + once. */ > + static std::unique_ptr init_files; > + if (init_files == nullptr) > + init_files = std::unique_ptr > + (new gdb_initfile_finder (GDBINIT, Just a nit, but I'd use an optional instead of a unique_ptr here, just because we don't need dynamic allocation. Otherwise, LGTM. Simon