From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Rao2INuZGmHkEAAAWB0awg (envelope-from ) for ; Mon, 16 Aug 2021 13:01:15 -0400 Received: by simark.ca (Postfix, from userid 112) id 70B4F1EDFB; Mon, 16 Aug 2021 13:01:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B172C1E4A3 for ; Mon, 16 Aug 2021 13:01:14 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 195FF3951E4A for ; Mon, 16 Aug 2021 17:01:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 195FF3951E4A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1629133274; bh=8JNUW2o+z3/8m6bqCDxpK2hqMibe6MFdomdvzEjFVpU=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=raK8P0I7eGv6FiwuMNeAPn8N+PTkrWzzIalTqB/uESouqPPJWgtT5vdqlsiiK6DM1 3qx60DGIsWJr6I2mqVf7RKELnVvgdcKNVF14Pixk3/otZrcJrUYS0j4e5bt7gyAQAR 2k0/tAf6rvQMqmKTx6G+bQLS35cZaya1BTF+M+RI= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 596F33958C2E for ; Mon, 16 Aug 2021 16:59:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 596F33958C2E Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 17GGxZNI032056 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Aug 2021 12:59:39 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 17GGxZNI032056 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id AD6121E4A3; Mon, 16 Aug 2021 12:59:34 -0400 (EDT) Subject: Re: Coding standards proposal, usage of "this" To: Christian Biesinger References: Message-ID: Date: Mon, 16 Aug 2021 12:59:34 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 16 Aug 2021 16:59:35 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: Simon Marchi via Gdb-patches Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >> - Use `this` when referring to a method of the current class. >> Rationale: without `this, it's not clear that you are referring to a >> method of the current class, versus a free function. > > I'm not really a fan of this, and I am also not aware of other > projects using such a style. Since this makes calling member functions > more verbose/uglier than calling free functions, this would also > discourage member functions. Is there a need to distinguish these? There's no *need*, of course. It's just based on my experience, I remember seeing some function calls, wondering how it could even work with the passed arguments. And then I realized it was a method call, where `this` is passed implicitly. Do you think it would discourage adding member functions, in opposition to adding free functions? Or just leaving the code in-line, leading to bigger methods? Simon