Re: [PATCH 0/7] Add "Windows" OS ABI

Jon Turney
2020-03-16T19:04:41Z

On 16/03/2020 17:48, Simon Marchi wrote:
> On 2020-03-16 1:46 p.m., Eli Zaretskii wrote:
>>> From: Simon Marchi <simon.marchi@polymtl.ca>
>>> Cc: Eli Zaretskii <eliz@gnu.org>,
>>> Jon Turney <jon.turney@dronecode.org.uk>,
>>> Simon Marchi <simon.marchi@polymtl.ca>
>>> Date: Mon, 16 Mar 2020 13:08:38 -0400
>>>
>>> This patchset started out as a single patch to have the OS ABI Cygwin
>>> applied to Windows x86-64 binaries, here:
>>>
>>> https://sourceware.org/legacy-ml/gdb-patches/2020-03/msg00195.html
>>>
>>> with the follow-up here:
>>>
>>> https://sourceware.org/pipermail/gdb-patches/2020-March/000022.html
>>>
>>> Eli pointed out that it doesn't make sense for binaries compilied with
>>> MinGW to have the Cygwin OS ABI, that there should be separate OS ABIs
>>> for Cygwin and non-Cygwin Windows binaries. This already came up in the
>>> following bug report:
>>>
>>> https://sourceware.org/bugzilla/show_bug.cgi?id=21500#add_comment
>>>
>>> This patchset does a bit of refactor in that area. Most importantly, it:
>>>
>>> - adds a "Windows" OS ABI
>>> - makes GDB recognize the proper OS ABI (Cygwin or Windows) when
>>> loading executables
>>> - makes the builtin long type on Cygwin be 64 bits long
>>
>> Thanks for working on this, the changes LGTM.
>>
>
> Thanks for taking a look, I'll give a bit more time for others (Jon might be
> interested) to take a look if and comment.

Patches look good, and appear work correctly in some brief testing.