From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id E3E86388B029 for ; Sun, 14 Jun 2020 16:58:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E3E86388B029 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 201A61E5F9; Sun, 14 Jun 2020 12:58:14 -0400 (EDT) Subject: Re: [PATCH] Fixing get_builder() function in dwarf2/read.c To: watashiwaher , gdb-patches@sourceware.org References: From: Simon Marchi Message-ID: Date: Sun, 14 Jun 2020 12:58:13 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jun 2020 16:58:16 -0000 On 2020-06-14 12:49 p.m., watashiwaher via Gdb-patches wrote: > Explanation > I found that some binaries with debug symbols halt gdb. And the problem was > in the get_builder() function inside dwarf2/read.c file. The function > recursively called itself until infinity. So I tried to fix this issue by > eliminating recursion and adding the check for cycle detection, and > returning nullptr if cycle detected. > > ChangeLog > 2020-06-15 Slava Mitin > > * dwarf2/read.c (get_builder): Added check for cycles Hi! Thanks for the patch. We try very hard to have a test case checked in for each fix like this. Would you be able to share a small reproducer (a small program that makes GDB crash like this) that we could turn into a test case? Simon