From: John Baldwin <jhb@FreeBSD.org>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simark@simark.ca>
Subject: Re: [PATCH] Conditionally restore displaced stepping state after fork.
Date: Mon, 31 May 2021 09:32:35 -0700 [thread overview]
Message-ID: <e834e53c-a4bd-9b4f-b84f-8e5e890d2283@FreeBSD.org> (raw)
In-Reply-To: <20210531161558.10600-1-jhb@FreeBSD.org>
On 5/31/21 9:15 AM, John Baldwin wrote:
> diff --git a/gdb/infrun.c b/gdb/infrun.c
> index e9624d2a9b..6fd077796f 100644
> --- a/gdb/infrun.c
> +++ b/gdb/infrun.c
> @@ -5496,7 +5496,8 @@ handle_inferior_event (struct execution_control_state *ecs)
> /* If this is a fork (child gets its own address space copy) and some
> displaced step buffers were in use at the time of the fork, restore
> the displaced step buffer bytes in the child process. */
> - if (ecs->ws.kind == TARGET_WAITKIND_FORKED)
> + if (ecs->ws.kind == TARGET_WAITKIND_FORKED
> + && gdbarch_supports_displaced_stepping (gdbarch))
> gdbarch_displaced_step_restore_all_in_ptid
> (gdbarch, parent_inf, ecs->ws.value.related_pid);
This appears to be a regression from 187b041e2514827b9d86190ed2471c4c7a352874
where previously stepping was only cleared from a single thread if it had
a stepping buffer (which implicitly was only true if the gdbarch supported
displaced stepping).
--
John Baldwin
next prev parent reply other threads:[~2021-05-31 16:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 16:15 John Baldwin
2021-05-31 16:32 ` John Baldwin [this message]
2021-06-01 0:59 ` Simon Marchi via Gdb-patches
2021-06-01 17:25 ` John Baldwin
2021-06-01 21:11 ` [PATCH v2] " John Baldwin
2021-06-01 21:18 ` Simon Marchi via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e834e53c-a4bd-9b4f-b84f-8e5e890d2283@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox