Re: [PATCH][gdb/testsuite] Fix PATH error in gdb_file_cmd

Tom de Vries
2020-06-04T11:51:19Z

On 04-06-2020 13:43, Pedro Alves wrote:
> On 6/4/20 11:24 AM, Tom de Vries wrote:
>> @@ -1800,7 +1801,7 @@ proc gdb_file_cmd { arg } {
>> return -1
>> }
>> -re "A problem internal to GDB has been detected" {
>> - fail "($arg) (GDB internal error)"
>> + fail "($basename) (GDB internal error)"
>> gdb_internal_error_resync
>> return -1
>> }
>
> The -re above has the exact same issue in the ERROR call.

Right, but the PATH detection is only for testnames, not for error messages.

> I have no idea why this one is a fail while everywhere else
> in the procedure perror is used. Seems inconsistent.

It is locally inconsistent indeed, but it is consistent with all other
handling of "A problem internal to GDB has been detected" in gdb.exp.

Thanks,
- Tom