From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114560 invoked by alias); 10 Oct 2017 19:02:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114275 invoked by uid 89); 10 Oct 2017 19:02:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Oct 2017 19:02:06 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 187A85F2981; Tue, 10 Oct 2017 19:02:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 187A85F2981 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 712C417AF8; Tue, 10 Oct 2017 19:02:04 +0000 (UTC) Subject: Re: [PATCH] get_integer_valueof: Don't output value in test name To: Simon Marchi , gdb-patches@sourceware.org References: <1507661462-32717-1-git-send-email-simon.marchi@ericsson.com> From: Pedro Alves Message-ID: Date: Tue, 10 Oct 2017 19:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1507661462-32717-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00257.txt.bz2 On 10/10/2017 07:51 PM, Simon Marchi wrote: > The get_integer_valueof outputs the value it has read as part of the > test name. This causes test names to vary from run to run, and adds > some noise when diffing test results. e.g.: > > -PASS: gdb.threads/process-dies-while-detaching.exp: multi-process: continue: killed outside: get integer valueof "mypid" (28770) > +PASS: gdb.threads/process-dies-while-detaching.exp: multi-process: continue: killed outside: get integer valueof "mypid" (32238) Ideally, test result diffing tools would be ignoring " (foo)" at the end test names, because that part is not considered a part of the test name itself. It's extra info. That's where we write "(timeout)", "(eof)", etc. So for instance: -PASS: gdb.threads/process-dies-while-detaching.exp: multi-process: continue: killed outside: get integer valueof "mypid" +FAIL: gdb.threads/process-dies-while-detaching.exp: multi-process: continue: killed outside: get integer valueof "mypid" (timeout) ... this should be considered a regression, instead of a new FAIL and a missing PASS. I think the buildbot diffing script is correctly ignoring that tail end "(foo)"s. That said, I think it's still a good idea to make the gdb.sum output more stable across passing runs, so that plain /usr/bin/diff also works reasonable well. > > This patch removes that, since it's probably not very useful. Since we can find the number in gdb.log if we need it, this is fine with me. Thanks, Pedro Alves