From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84123 invoked by alias); 20 Mar 2017 15:54:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84048 invoked by uid 89); 20 Mar 2017 15:54:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Mar 2017 15:54:51 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 41551C04B944; Mon, 20 Mar 2017 15:54:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 41551C04B944 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 41551C04B944 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id A18237445C; Mon, 20 Mar 2017 15:54:51 +0000 (UTC) Subject: Re: [PATCH 2/3] spu: Use ptid from regcache instead of inferior_ptid To: Simon Marchi , gdb-patches@sourceware.org References: <20170318170801.22988-1-simon.marchi@polymtl.ca> <20170318170801.22988-2-simon.marchi@polymtl.ca> From: Pedro Alves Message-ID: Date: Mon, 20 Mar 2017 15:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170318170801.22988-2-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-03/txt/msg00336.txt.bz2 On 03/18/2017 05:08 PM, Simon Marchi wrote: > The implementations of to_fetch_regiters/to_store_registers in the spu > code use some functions that rely on inferior_ptid. It's simpler for > now to set/restore inferior_ptid. > > * spu-linux-nat.c (spu_fetch_inferior_registers, > spu_store_inferior_registers): Use ptid from regcache, set and > restore inferior_ptid. > * spu-multiarch.c (spu_fetch_registers, spu_store_registers): > Likewise. > --- > gdb/spu-linux-nat.c | 24 ++++++++++++++++++++++-- > gdb/spu-multiarch.c | 26 ++++++++++++++++++++++++-- > 2 files changed, 46 insertions(+), 4 deletions(-) > > diff --git a/gdb/spu-linux-nat.c b/gdb/spu-linux-nat.c > index c5b91222c1..5ec7b65ad9 100644 > --- a/gdb/spu-linux-nat.c > +++ b/gdb/spu-linux-nat.c > @@ -492,9 +492,17 @@ spu_fetch_inferior_registers (struct target_ops *ops, > int fd; > ULONGEST addr; > > + /* Since we use functions that rely on inferior_ptid, we need to set and > + restore it. */ > + struct cleanup *cleanup = save_inferior_ptid (); > + inferior_ptid = regcache_get_ptid (regcache); > + Use a scoped_restore for all these? Like: scoped_restore save_ptid = make_scoped_restore (&inferior_ptid, regcache_get_ptid (regcache)); Thanks, Pedro Alves