From: Simon Marchi <simark@simark.ca>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Give up after consecutive timeouts in completion-support.exp
Date: Tue, 17 Mar 2020 11:00:21 -0400 [thread overview]
Message-ID: <e79139f0-6a79-8c44-b340-690a0b023d21@simark.ca> (raw)
In-Reply-To: <5ffff0ef-e2f6-82ea-306c-a661e9ae830c@suse.de>
On 2020-03-17 10:53 a.m., Tom de Vries wrote:
> Well, here's how I reasoned.
>
> Say for a string "abcdefgh" we test "a", "ab", "abc", etc.
>
> If we timeout at "a", there is the change that it's f.i. specific to
> one-letter matches, and such timeouts will not occur of "ab" and so on.
>
> So, we try to establish a pattern: if "a", "ab" and "abc" timeout, then
> we think there's a good chance that "abcd" will also timeout, and we
> give up.
>
> Having said that, my reasoning above is more concerned with not testing
> too little. Your reasoning is more concerned with having less timeouts.
> So I think both approaches are valid, they're just different trade-off
> points.
>
> I'm fine with submitting a follow up patch that gives up after the first
> timeout, if you prefer that.
>
> Thanks,
> - Tom
>
Ok, that's fine with me.
Simon
next prev parent reply other threads:[~2020-03-17 15:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 17:59 Tom de Vries
2020-03-17 8:06 ` Tom de Vries
2020-03-17 14:30 ` Simon Marchi
2020-03-17 14:53 ` Tom de Vries
2020-03-17 15:00 ` Simon Marchi [this message]
2020-03-19 6:58 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e79139f0-6a79-8c44-b340-690a0b023d21@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox