From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54316 invoked by alias); 3 Oct 2019 08:06:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54307 invoked by uid 89); 3 Oct 2019 08:06:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=H*r:IPv6 X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-2.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 Oct 2019 08:06:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1570089992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aehjqGoeiTv7FmUnttVJQMLAWzD2DJvOmFvVTxUMdcQ=; b=LYzkz2Q0KDn4NO1noOuVxkplFtNPbRP8jdyTLyIpkd8qToqEg8YBa47BZzlFUX0CGv7/lg LfoeVr/UYypjTO1oP88oGA5305CeVXAjdp0NvLAblVoiiqdRfV9SME+svXXbc25Dkmk+xq sqv1rKFCrMOIdmXEAwH6yYPWEFbS1Qc= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-78-B9nMtqTmPHSf2SxIkOvzXg-1; Thu, 03 Oct 2019 04:06:30 -0400 Received: by mail-wr1-f72.google.com with SMTP id t11so753822wro.10 for ; Thu, 03 Oct 2019 01:06:30 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id f13sm1910735wmj.17.2019.10.03.01.06.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Oct 2019 01:06:28 -0700 (PDT) Subject: Re: [PATCHv5 3/3] gdb: Remove a use of VEC from dwarf2read.{c,h} To: Andrew Burgess References: <8686aa422a9296daf14b844071a05fd443aea850.1569929786.git.andrew.burgess@embecosm.com> <276f2a6f-f2bf-b0ac-fe74-8ea8dba36297@redhat.com> <20191002222131.GD4962@embecosm.com> Cc: gdb-patches , Simon Marchi , Tom Tromey , markus.t.metzger@intel.com From: Pedro Alves Message-ID: Date: Thu, 03 Oct 2019 08:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20191002222131.GD4962@embecosm.com> X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-10/txt/msg00097.txt.bz2 On 10/2/19 11:21 PM, Andrew Burgess wrote: > * Pedro Alves [2019-10-02 16:50:57 +0100]: >=20 >> Hi, >> >> On 10/1/19 12:42 PM, Andrew Burgess wrote: >>> - VEC (sig_type_ptr) *tus; >>> + std::vector *tus; >> >> I skimmed this quickly and noticed that throughout the series >> you're putting a space in "vector <", which is not the prevailing >> style. >> >=20 > Sorry for this. I propose the below patch to address this mistake. Far from a big deal. :-) Thanks! Looks pretty obvious to me. Pedro Alves