Re: Proposal: format GDB Python files with black

[Luis Machado via Gdb-patches <gdb-patches@sourceware.org>]

On 5/11/21 10:49 AM, Simon Marchi wrote:
> On 2021-05-11 7:38 a.m., Luis Machado wrote:
>>> Indeed.  It's perhaps easy for me to say, because I get to choose what
>>> Linux distro and version I work on (so I opt for something recent), but
>>> I would still lean towards just following whatever the current latest
>>> stable version is.  There might be new options in the latest stable
>>> version we want to use, it would be nice not to have to wait years
>>> before we can use them.  And I suppose there's a not too painful way to
>>> get it for all the major distros out there (and for Windows and macOS,
>>> there are binary releases).  And you can always run it in Docker or
>>> something.
>>
>> I suppose we could have scripts to automate this sort of task. Something that checks for the latest stable release and downloads it? A helper to make things easier and more consistent.
> 
> Download from where?
> 

I guess this works better for black since you can fetch it from a repo 
and use a particular version.

Can we do something similar for clang-format without having to build the 
entire LLVM codebase?

>>
>> Can we do this server-side and take the burden off of the developers to have to do this as an additional step before pushing changes?
> 
> We can check server-side if the formatting is good and reject the commit
> if not, but I don't think we can modify the commit being pushed (I don't
> think it would be a good idea if that was possible).

I see. Maybe a client-side hook that formats things during a local 
commit will work better then.

That way we can send a local commit for review and it will be properly 
formatted already.

> 
> But just like black (it's on my todo list to check that), we can have a
> commit hook that runs clang-format (at least just to warn you, "Hey, you
> code needs to be formatted" if clang-format would change something).

I guess that would as well.