From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49674 invoked by alias); 22 Jun 2017 11:53:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49652 invoked by uid 89); 22 Jun 2017 11:53:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=H*RU:HELO, Hx-spam-relays-external:HELO, now, now! X-HELO: mga01.intel.com Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Jun 2017 11:53:50 +0000 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jun 2017 04:53:48 -0700 X-ExtLoop1: 1 Received: from wtedesch-mobl.ger.corp.intel.com (HELO [10.62.146.24]) ([10.62.146.24]) by orsmga003.jf.intel.com with ESMTP; 22 Jun 2017 04:53:46 -0700 Subject: Re: [PATCH 5/5] Add support for Intel PKRU register to GDB and GDBserver. To: Yao Qi References: <1485954205-18536-1-git-send-email-michael.sturm@intel.com> <1485954205-18536-6-git-send-email-michael.sturm@intel.com> <86a85355wz.fsf@gmail.com> <65548273-a6dc-5b74-f1b2-81d0a92c3a91@intel.com> <86wp8653bq.fsf@gmail.com> Cc: Simon Marchi , "Sturm, Michael" , "mark.kettenis@xs4all.nl" , "palves@redhat.com" , "eliz@gnu.org" , "gdb-patches@sourceware.org" From: "Tedeschi, Walfred" Message-ID: Date: Thu, 22 Jun 2017 11:53:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00639.txt.bz2 CgpBbSA2LzIyLzIwMTcgdW0gMTI6MzkgUE0gc2NocmllYiBZYW8gUWk6Cj4g T24gVGh1LCBKdW4gMjIsIDIwMTcgYXQgMTI6MTcgUE0sIFRlZGVzY2hpLCBX YWxmcmVkCj4gPHdhbGZyZWQudGVkZXNjaGlAaW50ZWwuY29tPiB3cm90ZToK Pj4gVGhhbmtzIGEgbG90IGZvciBkb2luZyB0aGlzIQo+PiBBdCBmaXJzdCBn bGFuY2UgZXZlcnl0aGluZyBsb29rcyBmaW5lLiAgSSB3aWxsIGdpdmUgaXQg YSB0cnkgaW4gc29tZQo+PiBoYXJkd2FyZSB3ZSBoYXZlIGFuZCBsZXQgeW91 IGtub3duLgo+PiBBbHNvLCBJIHdpbGwgdGFrZSBhIGNsb3NlciBsb29rIG9u IHRoZSBwYXRjaGVzLgo+Pgo+IFBsZWFzZSBwbGF5IHRoZW0gb24gc29tZSBo YXJkd2FyZSwgYW5kIGNvbW1lbnRzCj4gYXJlIHdlbGNvbWUuICBJIHRoaW5r IHRoaXMgcGF0Y2ggc2VyaWVzIHdpbGwgc2lnbmlmaWNhbnRseQo+IHNpbXBs aWZ5IHRhcmdldCBkZXNjcmlwdGlvbnMgZm9yIHZhcmlvdXMgSW50ZWwKPiBh cmNoaXRlY3R1cmUgZmVhdHVyZXMuCkkgYW0gZG9pbmcgaXQgcmlnaHQgbm93 ISBBbmQgeWVzIGl0IHNpbXBsaWZpZXMgYSBsb3QhClRoYW5rcyBhZ2FpbiEK Pj4gSSBhbHNvIHNhdyB0aGF0IGluIHRoZSBtaWRkbGUgb2YgeW91ciBwYXRj aGVzIHRoZXJlIGlzIGEgcGFydCBvZiB0aGUgZml4Cj4+IHRoYXQgU2ltb24g aXMgYXNraW5nIGhlcmUuCj4+IEJhc2ljYWxseSBhZGRpbmcgdGhlICJcIiBh bmQgcmVnZW5lcmF0aW5nIHRoZSByZW1vdmVzIG9uZSBvZiB5b3VyIGNvbW1p dHMuCj4+IERvIHlvdSB3YW50IG1lIHRvIHB1c2g/Cj4+Cj4gV2hhdCBpcyB0 aGF0PyAgSXMgaXQgbXkgcGF0Y2gKPiAiW1BBVENIIDIyLzI1XSBSZWdlbmVy YXRlIHR3byByZWdmb3JtYXRzL2kzODYvLmRhdCBmaWxlcyI/ICBGV0lXLCBp dAo+IHNob3VsZCBiZSBwdXNoZWQgaW4uClllcyB0aGlzIG9uZSEKCkludGVs IERldXRzY2hsYW5kIEdtYkgKUmVnaXN0ZXJlZCBBZGRyZXNzOiBBbSBDYW1w ZW9uIDEwLTEyLCA4NTU3OSBOZXViaWJlcmcsIEdlcm1hbnkKVGVsOiArNDkg ODkgOTkgODg1My0wLCB3d3cuaW50ZWwuZGUKTWFuYWdpbmcgRGlyZWN0b3Jz OiBDaHJpc3RpbiBFaXNlbnNjaG1pZCwgQ2hyaXN0aWFuIExhbXByZWNodGVy CkNoYWlycGVyc29uIG9mIHRoZSBTdXBlcnZpc29yeSBCb2FyZDogTmljb2xl IExhdQpSZWdpc3RlcmVkIE9mZmljZTogTXVuaWNoCkNvbW1lcmNpYWwgUmVn aXN0ZXI6IEFtdHNnZXJpY2h0IE11ZW5jaGVuIEhSQiAxODY5MjgK >From gdb-patches-return-140020-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Jun 22 11:59:40 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 57040 invoked by alias); 22 Jun 2017 11:59:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 57020 invoked by uid 89); 22 Jun 2017 11:59:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qk0-f181.google.com Received: from mail-qk0-f181.google.com (HELO mail-qk0-f181.google.com) (209.85.220.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Jun 2017 11:59:37 +0000 Received: by mail-qk0-f181.google.com with SMTP id d14so9819382qkb.1 for ; Thu, 22 Jun 2017 04:59:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=n1QZ+fPZtNEc3aojp2A5k8cGC+LhvhPRcvDM5kLNt7M=; b=NEWEK8e2D425v3rYFt/Ed9JHYBQKdgfm+b9a/UA+Ts4RkU1UIliTQID+MJB1Qp+oLG vm13aZcEEunetvOvXTn+lyCvvIfiCJrN0HInct+V1nc+Yn0JzCGLykznxG3k1wg5C3UJ UNt2z2ijnjiM1DNtb8WHB+QpNu0KTsjiWTGe5WM/TsAfuzp97vAvbMp98OiCAu8Ix55/ 2lI45Mw1aH8AwYEmFzt2zLrUhrsaCXqPuvZJ1tnSSHzlIFB0LfozGEJ2DY3NPPi7w7WW us/19R79lEy4eaGfkm8+II448DZT7+XonBh2jG2gRnsyT2L4gsOG6qT+xKuAPJh5ewnQ d74Q== X-Gm-Message-State: AKS2vOwi2/Ge6Rp0QqGbaQofw69pIla8i5TED/ylNfvz5daeyF0yJFrY /CCgUc//rG4DYWLmgCm0afUAWSn+0A== X-Received: by 10.55.114.1 with SMTP id n1mr2345468qkc.123.1498132776202; Thu, 22 Jun 2017 04:59:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.142.201 with HTTP; Thu, 22 Jun 2017 04:59:35 -0700 (PDT) In-Reply-To: <1565437a-a03e-1fa8-021a-a2d32de69a97@redhat.com> References: <86vanoi9zm.fsf@gmail.com> <1565437a-a03e-1fa8-021a-a2d32de69a97@redhat.com> From: Yao Qi Date: Thu, 22 Jun 2017 11:59:00 -0000 Message-ID: Subject: Re: [PATCH 2/2] gdb: Make some test names unique To: Pedro Alves Cc: Andrew Burgess , "gdb-patches@sourceware.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00640.txt.bz2 Content-length: 1740 On Thu, Jun 22, 2017 at 12:08 PM, Pedro Alves wrote: > On 06/22/2017 11:37 AM, Yao Qi wrote: >> Andrew Burgess writes: >> >> >>> mi_gdb_test "540-data-evaluate-expression vla1(1)" \ >>> - "540\\^done,value=3D\"1\"" "evaluate filled vla" >>> + "540\\^done,value=3D\"1\"" "evaluate filled vla(1)" >> >> Do not use "tail parentheses" on the test message, >> https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Do_not_use_.22tail_p= arentheses.22_on_test_messages > > The wiki doesn't mention it, but I think the rule should only apply when > there's a space before the parens. I wanted to get confirm from analyze-racy-logs.py, but I was lost in it, so I decided to follow the wiki. Andrew, your patch is OK as-is. > > I don't think it's worth it, or even a good idea to try to > come up with different test names for all of these. In cases like > these, I think it's generally possible to avoid the space before > the parens. So IMO, we should clarify the rule instead > (and the buildbot testresult diffing accordingly, if necessary). > The current rule is "When you write a test, do not put text between parentheses at the end of the text message", we can change it "when you write a test, do not put text between parentheses at the end of the text message and space before parentheses". They are OK, PASS: gdb.base/foo.exp: whatever test FAIL: gdb.base/foo.exp: whatever test (timeout) PASS: gdb.base/foo.exp: whatever test(1st) PASS: gdb.base/foo.exp: whatever test(2nd) They are not OK, PASS: gdb.trace/trace-break.exp: 2 trace trace on: trace set_point (1) PASS: gdb.trace/trace-break.exp: 2 trace trace on: trace set_point (2) Is it right? --=20 Yao (=E9=BD=90=E5=B0=A7)