From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124996 invoked by alias); 8 May 2018 20:47:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124981 invoked by uid 89); 8 May 2018 20:47:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=hitting, our X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 08 May 2018 20:47:53 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w48KlkM2026268 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 8 May 2018 16:47:51 -0400 Received: by simark.ca (Postfix, from userid 112) id 3362B1F216; Tue, 8 May 2018 16:47:46 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 347741E4F4; Tue, 8 May 2018 16:47:42 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 08 May 2018 20:47:00 -0000 From: Simon Marchi To: Pedro Alves Cc: Joel Brobecker , Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Define GNULIB_NAMESPACE in unittests/string_view-selftests.c In-Reply-To: <38335bd5-7e46-23e2-a45b-da970a1b8680@redhat.com> References: <1525382648-30186-1-git-send-email-simon.marchi@ericsson.com> <20180504165552.f4y7zcxzmgvwngel@adacore.com> <38335bd5-7e46-23e2-a45b-da970a1b8680@redhat.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 8 May 2018 20:47:46 +0000 X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00189.txt.bz2 On 2018-05-04 13:10, Pedro Alves wrote: > On 05/04/2018 05:55 PM, Joel Brobecker wrote: > >> What worries me is that I don't see what's preventing us from hitting >> that issue outside of the unittests code? We know we can adjust our >> own classes, but this problem occured with a system class, so we had >> no choice but to use GNULIB_NAMESPACE. I worry that the transition >> from no GNULIB_NAMESPACE to using GNULIB_NAMESPACE in a given unit >> will leave some C system calls that should normally be covered by >> gnulib silently now reverting to the system (buggy) version. > > Note that this is what led me to work on the whole wild/full matching > for C++, the TAB improvements, etc. See: > > https://sourceware.org/ml/gdb-patches/2017-06/msg00012.html > > I haven't rebased/updated the cxx-gdb-namespace branch since, as > I assumed it prudent to wait some time after a gdb is released > with support for wildmatching. That has happened, so maybe we can > consider going through with wrapping all of gdb in a namespace? > Or is it still too soon? > > Thanks, > Pedro Alves I pushed the patch to un-break the mingw build. Could you remind me what's the link between putting gdb in its own namespace and putting gnulib in its own namespace? How are they related? Simon