From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30888 invoked by alias); 1 Dec 2016 13:15:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30767 invoked by uid 89); 1 Dec 2016 13:15:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Dec 2016 13:15:51 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cCRDI-0003sI-IB from Luis_Gustavo@mentor.com ; Thu, 01 Dec 2016 05:15:48 -0800 Received: from [172.30.5.15] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 1 Dec 2016 05:15:45 -0800 Reply-To: Luis Machado Subject: Re: [PATCH v2 8/8] Fixup testcases outputting own name as a test name and standardize failed compilation messages References: <1480107244-1484-1-git-send-email-lgustavo@codesourcery.com> <1480107244-1484-9-git-send-email-lgustavo@codesourcery.com> <1f9fc5bc-7390-9734-f2ab-36b68e7f725b@redhat.com> To: Pedro Alves , From: Luis Machado Message-ID: Date: Thu, 01 Dec 2016 13:15:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1f9fc5bc-7390-9734-f2ab-36b68e7f725b@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-04.mgc.mentorg.com (147.34.90.204) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2016-12/txt/msg00028.txt.bz2 On 12/01/2016 05:08 AM, Pedro Alves wrote: > I thought I had sent this yesterday, but I now see I haven't.. > > On 11/25/2016 08:54 PM, Luis Machado wrote: >> --- a/gdb/testsuite/gdb.base/info-shared.exp >> +++ b/gdb/testsuite/gdb.base/info-shared.exp >> @@ -31,13 +31,13 @@ set define2 -DSHLIB2_NAME=\"$binfile_lib2\" >> >> if { [gdb_compile_shlib $srcfile_lib1 $binfile_lib1 \ >> [list additional_flags=-fPIC]] != "" } { >> - untested "could not compile $binfile_lib1." >> + untested "failed to compile shared library" >> return -1 >> } >> >> if { [gdb_compile_shlib $srcfile_lib2 $binfile_lib2 \ >> [list additional_flags=-fPIC]] != "" } { >> - untested "could not compile $binfile_lib2." >> + untested "failed to compile shared library" >> return -1 > > Duplicate test message. Write something like: > > untested "failed to compile shared library 1" > untested "failed to compile shared library 2" > > Another example (though unlike the above, this case was already > duplicate): > >> --- a/gdb/testsuite/gdb.base/attach.exp >> +++ b/gdb/testsuite/gdb.base/attach.exp >> @@ -30,14 +30,14 @@ remote_exec build "rm -f ${binfile} ${binfile2}" >> # build the first test case >> # >> if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } { >> - untested attach.exp >> + untested "failed to compile" >> return -1 >> } > > untested "failed to compile first test case" > >> >> # Build the in-system-call test >> >> if { [gdb_compile "${srcdir}/${subdir}/${srcfile2}" "${binfile2}" executable {debug}] != "" } { >> - untested attach.exp >> + untested "failed to compile" > > untested "failed to compile in-system-call test" > > > There are likely more instances in the patch. Since you're now reusing the same > string on all tests, I think it should be easy to grep (+sort+uniq) > for "failed to compile" to catch them. Could you do that? > > Thanks, > Pedro Alves > Sure. I'll get those addressed.