Re: [PATCH] [pre-commit] Stop using deprecated language script

[Simon Marchi <simark@simark.ca>]

On 6/16/26 11:32 AM, Tom de Vries wrote:
> On 6/16/26 3:46 PM, Simon Marchi wrote:
>> On 6/16/26 5:23 AM, Tom de Vries wrote:
>>> In v4.4.0, pre-commit renamed language script to unsupported_script.
>>>
>>> The rename was done to stress that pre-commit doesn't provide an environment
>>> for the script to run in [1].
>>>
>>> The language script is now a deprecated alias for unsupported_script, and the
>>> plan seems to be to initially produce a deprecation warning, and eventually
>>> remove support for the alias completely.
>>>
>>> Start using the new name: unsupported_script.
>>>
>>> Furthermore, the check-include-guards hook uses language python, and indeed it
>>> uses a python script, but it doesn't really need a virtual environment.  It
>>> imports modules fnmatch, re, sys and typing, all of which are available in
>>> python 3.10 and later, which is the environment pre-commit itself requires
>>> (because we require pre-commit v4.5.1 or later, and pre-commit requires python
>>> 3.10 since v4.4.0).  So while we're at it, use unsupported_script for this
>>> hook as well, reducing the amount of environments pre-commit has to manage.
>>>
>>> Tested using "pre-commit run --all-files" with python 3.10, as well as 3.13.
>>>
>>> [1] https://github.com/pre-commit/pre-commit/pull/3577
>>
>>  From reading the pre-commit doc, I didn't understand the difference
>> between "unsupported_script" and "unsupported", did you?
> 
> Not really.
> 
> The difference seems to be that for unsupported_script "the entry should be a path relative to the root of the hook repository".
> 
> Concretely, a hook like this using unsupported_script works:
> ...
>     - id: bla
>       name: bla
>       language: unsupported
>       entry: sh -c "echo bla; exit 1"
> ...
> 
> Changing the language to unsupported_script gets us: "Executable `/data/vries/gdb/binutils-gdb.git/sh"` not found.
> 
> To get the same effect, we need:
> ...
>     - id: bla
>       name: bla
>       language: unsupported_script
>       entry: /usr/bin/sh -c "echo bla; exit 1"
> ...
> 
> Note that this version also works fine with language unsupported.
> 
> The intent seems to be that unsupported_script is reserved for in-repo scripts, and unsupported is the fallback that supports anything else.   

Ok, make sense.  LGTM then.

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon