Re: [PATCH 03/16] Introduce ui_file_style

Tom Tromey
2018-12-28T18:54:49Z

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

>> + /* Can't call this for a basic color. */

Joel> I am trying to understand this comment, as well as the corresponding
Joel> comment describing this method (in ui-style.h):

Joel> + This may not be called for simple colors or for the "NONE"
Joel> + color. */

Joel> Does it look like you can, in fact, call this method on
Joel> a simple color?

Yeah. The naming was confusing here, so I have cleaned it up by
renaming "enum simple_color" to "enum basic_color". You can call this
method for any "simple" (scalar) color that isn't a basic color or NONE,
simply because we don't have RGB values for these.

>> + ui_file_style ()
>> + {
>> + }

Joel> Sorry for the obvious C++ question - Does this constructor means
Joel> that the default constructor results in an object with undefined
Joel> data? Or is that the same as...

Joel> ui_file_style () = default;

It's the same, I have changed the code to use the "= default" form.

Joel> I think there might be a copy-pasto in the comment: N_READ -> BYTES?

I fixed this.

Tom