From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 1FVoHRQrfWm71x4AWB0awg (envelope-from ) for ; Fri, 30 Jan 2026 17:05:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1769810708; bh=4MHcwKTvswFtLZaLYGE0ezNHBd+y0d6YhFIBmv5cdHo=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=EMTkPQ9luNAE9Roxsyct/6Ymp5Fa44ZuiWYgGNUqT7KdRkyR5tTM2TkxifCN8fhh+ 35/yMsAf2cWP1tgCULF68tY0yQPDg2DG8wsTGXNP/XGOXHblNrjDuropEW3UF2y3VK mBXlrO6VpVVYrm20m9uOWi3AJaH+Z0/XrYKYzZC0= Received: by simark.ca (Postfix, from userid 112) id 668B51E089; Fri, 30 Jan 2026 17:05:08 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=nug2eO37; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AA9B51E089 for ; Fri, 30 Jan 2026 17:05:07 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 314D14BA23DA for ; Fri, 30 Jan 2026 22:05:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 314D14BA23DA Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=nug2eO37 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 463AA4BA2E07 for ; Fri, 30 Jan 2026 22:04:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 463AA4BA2E07 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 463AA4BA2E07 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769810682; cv=none; b=j3+/Rix7ti3p37q/HQlPAsdxKhJQZXVc6fJ7nFrkDJiFrQfQCkpXMGtla3OWI50BGk1O4+I2LOqWsieOOr/yg5BsBQAi1LBNmpluK7FPDBWzBy8emvu+PUMTEch5TnHeDvhw/kGCZi/LM9aZVYJweAj0tIKoAaWA3gLrQWzDCS8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769810682; c=relaxed/simple; bh=4MHcwKTvswFtLZaLYGE0ezNHBd+y0d6YhFIBmv5cdHo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=jzhnGvxSQsPL0pQSb6LY4TJh7iXGg6MZyPrS0YDiQzi+o1H5mwc35Cqi0QP2hYl0Cuxq7Y9stIFxVQMDXsE+1PGAf4zrizuPE+JyQ5wW5UDkQOgtOjg6dfQfEzdQfjwu8kfhIck7bkT22FV5Xnzcikuqs6d0Ap4F4jV9SCDc6ZY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 463AA4BA2E07 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1769810681; bh=4MHcwKTvswFtLZaLYGE0ezNHBd+y0d6YhFIBmv5cdHo=; h=Date:Subject:To:References:From:In-Reply-To:From; b=nug2eO37HR+eSmdN3O4Fyy4yjktjNnRi+tfW2k8SvAssLKxVqsivfcbRzfNhBV7O6 T1MZwwvyq2wW6+/Os41gxAWgVZzBXy7MQlSBCNnLTdzproYB+CO4BmRHei6XC7zAbO 9EmzTJLw10GdjI9dk2LJTwhVCkXzHfcBMENESPGA= Received: by simark.ca (Postfix) id A47CF1E089; Fri, 30 Jan 2026 17:04:41 -0500 (EST) Message-ID: Date: Fri, 30 Jan 2026 17:04:41 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/8] Have iterate_over_one_compunit_symtab search included symtabs To: Tom Tromey , gdb-patches@sourceware.org References: <20260126-dw-inline-fixup-pr-symtab-30728-2-v2-0-8ab183d1911c@tromey.com> <20260126-dw-inline-fixup-pr-symtab-30728-2-v2-6-8ab183d1911c@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20260126-dw-inline-fixup-pr-symtab-30728-2-v2-6-8ab183d1911c@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-01-26 16:33, Tom Tromey wrote: > @@ -257,10 +262,14 @@ objfile::map_symtabs_matching_filename > > auto listener = [&] (compunit_symtab *symtab) > { > + /* Skip included compunits. */ > + if (symtab->user != nullptr) > + return true; It would be nice for the comment to say why we skip included compunits: because iterate_over_one_compunit_symtab searches recursively. Simon