From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88418 invoked by alias); 28 Nov 2016 16:06:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88402 invoked by uid 89); 28 Nov 2016 16:06:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=00pm, Hx-languages-length:1438, letter, wish X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 28 Nov 2016 16:06:34 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cBORs-0001c6-6o from Luis_Gustavo@mentor.com ; Mon, 28 Nov 2016 08:06:32 -0800 Received: from [172.30.6.41] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Mon, 28 Nov 2016 08:06:29 -0800 Reply-To: Luis Machado Subject: Re: [PATCH v2 4/8] Fix test names starting with uppercase using gdb_test_multiple References: <1480107244-1484-1-git-send-email-lgustavo@codesourcery.com> <1480107244-1484-5-git-send-email-lgustavo@codesourcery.com> <20161127170947.32vzeqciax5v275h@localhost> To: Yao Qi CC: From: Luis Machado Message-ID: Date: Mon, 28 Nov 2016 16:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161127170947.32vzeqciax5v275h@localhost> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-01.mgc.mentorg.com (147.34.90.201) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00917.txt.bz2 On 11/27/2016 11:09 AM, Yao Qi wrote: > On Fri, Nov 25, 2016 at 02:54:00PM -0600, Luis Machado wrote: >> This fixes offender testcases that have test names starting with uppercase >> when using gdb_test_multiple in a single-line construct. >> >> gdb/testsuite/ChangeLog >> 2016-11-25 Luis Machado >> >> Fix test names starting with uppercase throughout the files. >> >> * gdb/testsuite/gdb.arch/i386-bp_permanent.exp >> * gdb/testsuite/gdb.arch/i386-gnu-cfi.exp >> * gdb/testsuite/gdb.base/disasm-end-cu.exp >> * gdb/testsuite/gdb.base/macscp.exp >> * gdb/testsuite/gdb.base/pending.exp >> * gdb/testsuite/gdb.base/watch_thread_num.exp >> * gdb/testsuite/gdb.cp/exception.exp >> * gdb/testsuite/gdb.cp/gdb2495.exp >> * gdb/testsuite/gdb.cp/local.exp >> * gdb/testsuite/gdb.python/py-evsignal.exp >> * gdb/testsuite/gdb.python/python.exp >> * gdb/testsuite/gdb.trace/tracecmd.exp > > Drop "gdb/testsuite/". Patch is good to me, but I think we need to > enforce a rule in "proc gdb_test_multiple" that test message should > start with a lower case letter, emit an ERROR if it starts with > uppercase. > Do you mean just for gdb_test_multiple? It can be tricky, since one is still free to start the sentences with something like "ARM ..." or some other technology name. So unfortunately we can't be too strict. I wish we could.