From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68909 invoked by alias); 25 Oct 2018 15:25:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68659 invoked by uid 89); 25 Oct 2018 15:25:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS,SPF_PASS autolearn=ham version=3.3.2 spammy=emaisin, HTo:U*tom X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Oct 2018 15:25:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1540481116; x=1543073116; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=tIVuE4uLe+XxZSmAQtltjHGH3MbAh+n3bZSMk9C58bQ=; b=gu3pWr2gCzkeKewdjsHnCSeNgBhNpBJwlGI9br6jpdmuFe3sX6w3MEIF0iAY8KxP Me9wg5jZu5MtWV2F5Kbl5RhGuJIJp3Nv/ICPUgrPTXL/N1Zoo/c0AYd+im3QbbFP WPfHqooSPnHHGM7GRBeKIbdBdMxt9b9n64PGn120VYc=; Received: from ESESSMB502.ericsson.se (Unknown_Domain [153.88.183.120]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 1E.E8.25521.C50E1DB5; Thu, 25 Oct 2018 17:25:16 +0200 (CEST) Received: from ESESSMB501.ericsson.se (153.88.183.162) by ESESSMB502.ericsson.se (153.88.183.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Thu, 25 Oct 2018 17:25:16 +0200 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Thu, 25 Oct 2018 17:25:15 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tIVuE4uLe+XxZSmAQtltjHGH3MbAh+n3bZSMk9C58bQ=; b=ipgNl/jBA1Vowh/g72952OyEDa2LKfu5A5fXfeGmrOYEA8ihvmytgQTBqB5ZxVxR+jegM9GAd2RV4x+A2O7aouGJHCV6kxKAZ+aOba+N1iCdEf17+WIcQ7LHjD/9ffoIYNoROOCbzSGgeeTSwsTzxd8Uzx6bIzVKfcgg6emvS0I= Received: from BYAPR15MB2390.namprd15.prod.outlook.com (52.135.198.30) by BYAPR15MB2213.namprd15.prod.outlook.com (52.135.196.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1250.20; Thu, 25 Oct 2018 15:25:13 +0000 Received: from BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::649a:ddbf:ecc5:1f0a]) by BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::649a:ddbf:ecc5:1f0a%3]) with mapi id 15.20.1273.019; Thu, 25 Oct 2018 15:25:13 +0000 From: Simon Marchi To: Tom Tromey , "gdb-patches@sourceware.org" Subject: Re: [PATCH] Check return value of bfd_init Date: Thu, 25 Oct 2018 15:25:00 -0000 Message-ID: References: <20181025150340.28844-1-tom@tromey.com> In-Reply-To: <20181025150340.28844-1-tom@tromey.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: <9D0D7074A1019C4FB3AC990C930AB1EE@namprd15.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Return-Path: simon.marchi@ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00580.txt.bz2 T24gMjAxOC0xMC0yNSAxMTowMyBhLm0uLCBUb20gVHJvbWV5IHdyb3RlOg0K PiBBbGFuIHJlY2VudGx5IGFkZGVkIGEgd2F5IGZvciBCRkQgbGlicmFyeSB1 c2VycyB0byBjaGVjayB3aGV0aGVyIHRoZXkNCj4gd2VyZSBpbiBmYWN0IGxv YWRpbmcgYSBjb21wYXRpYmxlIHZlcnNpb24gb2YgQkZEOg0KPiANCj4gaHR0 cHM6Ly9zb3VyY2V3YXJlLm9yZy9tbC9iaW51dGlscy8yMDE4LTEwL21zZzAw MTk4Lmh0bWwNCj4gDQo+IEl0IHNlZW1lZCByZWFzb25hYmxlIHRvIG1lIHRo YXQgZ2RiIHNob3VsZCBkbyB0aGlzIGNoZWNrIGFzIHdlbGwsIGluDQo+IGNh c2Ugc29tZW9uZSBpcyBkeW5hbWljYWxseSBsaW5raW5nIGFnYWluc3QgQkZE LiAgVGVzdGVkIGJ5IHJlYnVpbGRpbmcNCj4gYW5kIHRoZW4gc3RhcnRpbmcg dGhlIHJlc3VsdGluZyBnZGIuDQo+IA0KPiBnZGIvQ2hhbmdlTG9nDQo+IDIw MTgtMTAtMjUgIFRvbSBUcm9tZXkgIDx0b21AdHJvbWV5LmNvbT4NCj4gDQo+ IAkqIG1haW4uYyAoY2FwdHVyZWRfbWFpbl8xKTogQ2hlY2sgcmV0dXJuIHZh bHVlIG9mIGJmZF9pbml0Lg0KPiAtLS0NCj4gIGdkYi9DaGFuZ2VMb2cgfCA0 ICsrKysNCj4gIGdkYi9tYWluLmMgICAgfCAzICsrLQ0KPiAgMiBmaWxlcyBj aGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkNCj4gDQo+ IGRpZmYgLS1naXQgYS9nZGIvQ2hhbmdlTG9nIGIvZ2RiL0NoYW5nZUxvZw0K PiBpbmRleCA2MWRjMDM5ZDRmZS4uYTkwYzI5NzgxODUgMTAwNjQ0DQo+IC0t LSBhL2dkYi9DaGFuZ2VMb2cNCj4gKysrIGIvZ2RiL0NoYW5nZUxvZw0KPiBA QCAtMSwzICsxLDcgQEANCj4gKzIwMTgtMTAtMjUgIFRvbSBUcm9tZXkgIDx0 b21AdHJvbWV5LmNvbT4NCj4gKw0KPiArCSogbWFpbi5jIChjYXB0dXJlZF9t YWluXzEpOiBDaGVjayByZXR1cm4gdmFsdWUgb2YgYmZkX2luaXQuDQo+ICsN Cj4gIDIwMTgtMTAtMjUgIEFuZHJldyBCdXJnZXNzICA8YW5kcmV3LmJ1cmdl c3NAZW1iZWNvc20uY29tPg0KPiAgDQo+ICAJKiBweXRob24vcHktZnVuY3Rp b24uYyAoY29udmVydF92YWx1ZXNfdG9fcHl0aG9uKTogUmV0dXJuDQo+IGRp ZmYgLS1naXQgYS9nZGIvbWFpbi5jIGIvZ2RiL21haW4uYw0KPiBpbmRleCA4 NzA5MzU3ZTkyNC4uOTZkZWYzMDgwZWIgMTAwNjQ0DQo+IC0tLSBhL2dkYi9t YWluLmMNCj4gKysrIGIvZ2RiL21haW4uYw0KPiBAQCAtNTA2LDcgKzUwNiw4 IEBAIGNhcHR1cmVkX21haW5fMSAoc3RydWN0IGNhcHR1cmVkX21haW5fYXJn cyAqY29udGV4dCkNCj4gICAgdGV4dGRvbWFpbiAoUEFDS0FHRSk7DQo+ICAj ZW5kaWYNCj4gIA0KPiAtICBiZmRfaW5pdCAoKTsNCj4gKyAgaWYgKGJmZF9p bml0ICgpICE9IEJGRF9JTklUX01BR0lDKQ0KPiArICAgIGVycm9yIChfKCJm YXRhbCBlcnJvcjogbGliYmZkIEFCSSBtaXNtYXRjaCIpKTsNCj4gICAgbm90 aWNlX29wZW5fZmRzICgpOw0KPiAgDQo+ICAgIHNhdmVkX2NvbW1hbmRfbGlu ZSA9IChjaGFyICopIHhzdHJkdXAgKCIiKTsNCj4gDQoNCkl0IGRvZXNuJ3Qg d29yayB0byBjYWxsIGVycm9yIHRoYXQgZWFybHkuICBUcnkgdG8gcmV2ZXJz ZSB0aGUgY29uZGl0aW9uIGFuZCBzdGFydA0KZ2RiLCB5b3UnbGwgZ2V0Og0K DQokIC4vZ2RiDQpBU0FOOlNJR1NFR1YNCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 DQo9PTEyOTQ3PT1FUlJPUjogQWRkcmVzc1Nhbml0aXplcjogU0VHViBvbiB1 bmtub3duIGFkZHJlc3MgMHgwMDAwMDAwMDAwOTAgKHBjIDB4MDAwMDAxM2E3 YTJmIGJwIDB4N2ZmY2JkMDQ4NTEwIHNwIDB4N2ZmY2JkMDQ4NDYwIFQwKQ0K ICAgICMwIDB4MTNhN2EyZSBpbiBnZGJfbWFpbihjYXB0dXJlZF9tYWluX2Fy Z3MqKSAvaG9tZS9lbWFpc2luL3NyYy9iaW51dGlscy1nZGIvZ2RiL21haW4u YzoxMTk0DQogICAgIzEgMHhiMjcwOTggaW4gbWFpbiAvaG9tZS9lbWFpc2lu L3NyYy9iaW51dGlscy1nZGIvZ2RiL2dkYi5jOjMyDQogICAgIzIgMHg3ZmYy NDQzMTQ4MmYgaW4gX19saWJjX3N0YXJ0X21haW4gKC9saWIveDg2XzY0LWxp bnV4LWdudS9saWJjLnNvLjYrMHgyMDgyZikNCiAgICAjMyAweGIyNmVmOCBp biBfc3RhcnQgKC9ob21lL2VtYWlzaW4vYnVpbGQvYmludXRpbHMtZ2RiL2dk Yi9nZGIrMHhiMjZlZjgpDQoNCkFkZHJlc3NTYW5pdGl6ZXIgY2FuIG5vdCBw cm92aWRlIGFkZGl0aW9uYWwgaW5mby4NClNVTU1BUlk6IEFkZHJlc3NTYW5p dGl6ZXI6IFNFR1YgL2hvbWUvZW1haXNpbi9zcmMvYmludXRpbHMtZ2RiL2dk Yi9tYWluLmM6MTE5NCBnZGJfbWFpbihjYXB0dXJlZF9tYWluX2FyZ3MqKQ0K PT0xMjk0Nz09QUJPUlRJTkcNCg0KDQpTbyBmcHJpbnRmIHRvIHN0ZGVyciBh bmQgZXhpdCBpbnN0ZWFkPw0KDQpTaW1vbg0K >From gdb-patches-return-151865-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Oct 25 15:31:24 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 77245 invoked by alias); 25 Oct 2018 15:31:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 77115 invoked by uid 89); 25 Oct 2018 15:31:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (50.116.125.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Oct 2018 15:31:16 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 736B137F3A for ; Thu, 25 Oct 2018 10:31:15 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Fhb1gz73dSjJAFhbFgSvCr; Thu, 25 Oct 2018 10:31:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PoqHkP+DGvr5GosFUhAXOFoIkUgrpvAeRdOhAmLeOd4=; b=bbCiT+IVlAQ+jrlkOzc1Be/n0q PZlTGj3rkOgHRcQr+x+gugRFKKZrIo50x4SNl27zwdEMHLDKi1euWdKmu7if3+NoWEnntCZVbgsRp jzgAc+L3pxTA0cRl5UUhVSjxq; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:39324 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gFhb1-002ajI-17; Thu, 25 Oct 2018 10:30:51 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , "gdb-patches\@sourceware.org" Subject: Re: [PATCH] Check return value of bfd_init References: <20181025150340.28844-1-tom@tromey.com> Date: Thu, 25 Oct 2018 15:31:00 -0000 In-Reply-To: (Simon Marchi's message of "Thu, 25 Oct 2018 15:25:13 +0000") Message-ID: <87efcehwlx.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-10/txt/msg00583.txt.bz2 Content-length: 320 >>>>> "Simon" == Simon Marchi writes: Simon> It doesn't work to call error that early. Sorry about that. For me the problem isn't the call to error, it is a crash in gdb_main when trying to call exception_print. Moving the call to bfd_init below the call to "new ui" makes it work. Tom