From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-142241-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32693 invoked by alias); 3 Oct 2017 15:15:49 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 32658 invoked by uid 89); 3 Oct 2017 15:15:46 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Oct 2017 15:15:45 +0000
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id E120281236;	Tue,  3 Oct 2017 15:15:43 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E120281236
Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id 3E5145D9CD;	Tue,  3 Oct 2017 15:15:42 +0000 (UTC)
Subject: Re: [PATCH v5 3/3] Extend "set cwd" to work on gdbserver
To: Sergio Durigan Junior <sergiodj@redhat.com>, GDB Patches <gdb-patches@sourceware.org>
References: <20170912042325.14927-1-sergiodj@redhat.com> <20170929225852.21872-1-sergiodj@redhat.com> <20170929225852.21872-4-sergiodj@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>
From: Pedro Alves <palves@redhat.com>
Message-ID: <e65fcd1b-e056-e623-a161-f95bfe1c3279@redhat.com>
Date: Tue, 03 Oct 2017 15:15:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20170929225852.21872-4-sergiodj@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-10/txt/msg00048.txt.bz2

This version looks good to me, with one tiny nit below.

On 09/29/2017 11:58 PM, Sergio Durigan Junior wrote:

> +/* Helper function to set the current working directory for the
> +   inferior in the remote.  */

"in the remote" sounds a bit odd.  Missing word?
Maybe "remote target."?

> +
> +static void
> +extended_remote_set_inferior_cwd (struct remote_state *rs)
> +{

Thanks,
Pedro Alves