From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id q102MW93d2Ne3xkAWB0awg (envelope-from ) for ; Fri, 18 Nov 2022 07:15:43 -0500 Received: by simark.ca (Postfix, from userid 112) id B8AD71E124; Fri, 18 Nov 2022 07:15:43 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=msjAYaVg; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_REPLYTO_END_DIGIT,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 59F931E0D3 for ; Fri, 18 Nov 2022 07:15:43 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AF770384D98E for ; Fri, 18 Nov 2022 12:15:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AF770384D98E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1668773742; bh=7QSk0n75U72fy5QuEUN4sR50ieuz+WipCdJ/jKagW2U=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=msjAYaVg/sgR2/B7BfnY2looUCa4fNXRdPMDZF3VnKMmc9jqO8rWytXNyqMvymCJQ BGgU8SH1+LmYmHs8AcMRvynU0Ppnb5weZkKdn9TCRybuqvw/uDziBdRnEWFGmP88qM kxGsK3nWmcbqMCup4mDXC4Ckjea/emHvpGMual7w= Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id 740CA384F48F for ; Fri, 18 Nov 2022 12:14:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 740CA384F48F Received: by mail-pg1-x532.google.com with SMTP id s196so4865121pgs.3 for ; Fri, 18 Nov 2022 04:14:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7QSk0n75U72fy5QuEUN4sR50ieuz+WipCdJ/jKagW2U=; b=RXVS48i5cpV3mYwd5fUpHBYr+2JDWDnawMWeaf30ZuWAFdLcAAjY2E9ukQPMQQe1eS MywlQrWH0RxDLXJmWQD6kst5KhQ5YKJYSyUtvhT301DIjEUVyHKRl+ZEikOKGr167PFQ QGQm5/DJetCZ4KB6V+0vUxg++wzq8Cdb3BasAA9DQG6o5W9/cidSofHeWPj6t3x3gU5+ xG3QimEgRZJgfziepNmewBFxYC2C3kmE0Y/NNv9kr8XLEQR4zmh3WuP38m10TjI6UyRm SBpD6j2JPkGOsB2Eh/kGSu8oO/gqjC7WpLH2EVf7sV9gpnCEZUEyG/h85W42L4ZggXFa YJQg== X-Gm-Message-State: ANoB5pmGkmRUMA/qjQpE4ZOs9PggNurOWKg6L27uPs71Z4bDx4Q/2O8w iDJ/Cgo/loPgX6vwKGHt/44= X-Google-Smtp-Source: AA0mqf7ytToE1hG4YlwQkwyPeJUtjBZWPK8EJNuu8a01QpXl8fUNNywdDfk2Yye86iYrj+VYjUzHbw== X-Received: by 2002:a62:ed03:0:b0:558:99cc:8b40 with SMTP id u3-20020a62ed03000000b0055899cc8b40mr7487975pfh.25.1668773674320; Fri, 18 Nov 2022 04:14:34 -0800 (PST) Received: from [192.168.0.100] (intel10.cs.nthu.edu.tw. [140.114.89.60]) by smtp.gmail.com with ESMTPSA id ix11-20020a170902f80b00b001788ccecbf5sm3451141plb.31.2022.11.18.04.14.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Nov 2022 04:14:33 -0800 (PST) Message-ID: Date: Fri, 18 Nov 2022 20:14:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: [PING^2] [PATCH v2] [gdb/python] Replace gdbpy_should_stop with gdbpy_breakpoint_cond_says_stop Content-Language: en-US To: BrunoLarsen , gdb-patches@sourceware.org References: <20220923060027.78902-1-j3.soon777@gmail.com> <20221020182456.2701-1-j3.soon777@gmail.com> In-Reply-To: <20221020182456.2701-1-j3.soon777@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Johnson Sun via Gdb-patches Reply-To: Johnson Sun Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Ping for: . Johnson On 10/21/2022 2:24 AM, Johnson Sun wrote: > In 2014, the function `gdbpy_should_stop' has been replaced with > `gdbpy_breakpoint_cond_says_stop' > > This replaces `gdbpy_should_stop' with `gdbpy_breakpoint_cond_says_stop' in the > comments. > > Since `gdbpy_should_stop' has been renamed as noted in `gdb/ChangeLog-2014': > > * python/py-breakpoint.c (gdbpy_breakpoint_cond_says_stop): Renamed > from gdbpy_should_stop. Change result type to enum scr_bp_stop. > --- > gdb/python/py-finishbreakpoint.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/python/py-finishbreakpoint.c b/gdb/python/py-finishbreakpoint.c > index c80096f6810..dcf86317779 100644 > --- a/gdb/python/py-finishbreakpoint.c > +++ b/gdb/python/py-finishbreakpoint.c > @@ -90,7 +90,7 @@ bpfinishpy_dealloc (PyObject *self) > Py_TYPE (self)->tp_free (self); > } > > -/* Triggered when gdbpy_should_stop is about to execute the `stop' callback > +/* Triggered when gdbpy_breakpoint_cond_says_stop is about to execute the `stop' callback > of the gdb.FinishBreakpoint object BP_OBJ. Will compute and cache the > `return_value', if possible. */ > > @@ -134,7 +134,7 @@ bpfinishpy_pre_stop_hook (struct gdbpy_breakpoint_object *bp_obj) > } > } > > -/* Triggered when gdbpy_should_stop has triggered the `stop' callback > +/* Triggered when gdbpy_breakpoint_cond_says_stop has triggered the `stop' callback > of the gdb.FinishBreakpoint object BP_OBJ. */ > > void