From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id uJ8EC67/v2nLRjQAWB0awg (envelope-from ) for ; Sun, 22 Mar 2026 10:41:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1774190510; bh=4Tmi6xdjgG8m646MQqILVIqJZoJeUmMkJe5E6f9PAe0=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=svdvsnTsRWTmqG9OATRPUPuGFytUttpQMZ8v/kFJeQz75phmFNJXA4LlbWH/IPBQC B5pdeWTApnkDFWyRpvUGMXIlv25uZKnnMzweVa1AMtiRtAhwvdfQYBtbF75A3ZvpkZ 6yUVNgmDBZCtFp8yCTJjt3m8Ppx0D7CIsJ27OKiY= Received: by simark.ca (Postfix, from userid 112) id 1D2741E08C; Sun, 22 Mar 2026 10:41:50 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=XUaeKIgY; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BB4B11E08C for ; Sun, 22 Mar 2026 10:41:48 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 3C8654BAE7F5 for ; Sun, 22 Mar 2026 14:41:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3C8654BAE7F5 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=XUaeKIgY Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 87CEC4BAE7DA for ; Sun, 22 Mar 2026 14:41:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 87CEC4BAE7DA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 87CEC4BAE7DA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774190482; cv=none; b=dyR0JcfjFTSIN8B9B2GYaNyOvcnEOvl0E1VJIA5ZHR5lBCNUQ9VnaHy2UvCGN5Lj4sk9/oSUJAfD8I4ikVB6S3D+EZsTIn603m8IKpAVBVskW2FAWbpDiCrVSwi16h73rrYFo67d8s0HCGVkW3l1w9Aoo23Ohgq0AyQofHSdK9c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774190482; c=relaxed/simple; bh=4Tmi6xdjgG8m646MQqILVIqJZoJeUmMkJe5E6f9PAe0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ZiWhG6pWroOJ4kKuoH9fz8J3/XGFSULcmxw+1nsIhinE2z5oEMvaM5u8iVVaBLsRELCELn/LPoPgeTHSMAEeqiDCp0toCzVCzH5bkPrZ1wv2P8amc0pGApFEN8DYFpvX3ECXlQ3VTppIUep29pTbS2x3dg2u/e2CrX189xniqxw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 87CEC4BAE7DA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1774190480; bh=4Tmi6xdjgG8m646MQqILVIqJZoJeUmMkJe5E6f9PAe0=; h=Date:Subject:To:References:From:In-Reply-To:From; b=XUaeKIgYmHMs/wSwrdSyUCDJ6jhDWudIvhlxx/OEe/TIUDIpZmzaSy+6jK+sXS3Iy CoiBzWKTbZAGD/s2qSvhHn6cwCoXDwxMRI4zzEA1E6OFu9mij/XuSbKswqfplfYYXt yIgkQ0gvPgDWIfBTBOJhIEbz8LjQrTkKbD1we2ss= Received: by simark.ca (Postfix) id 545501E08C; Sun, 22 Mar 2026 10:41:19 -0400 (EDT) Message-ID: Date: Sun, 22 Mar 2026 10:41:18 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/tdep] Eliminate ostringstream use from arc_check_tdesc_feature To: Tom de Vries , gdb-patches@sourceware.org References: <20260322065808.1127765-1-tdevries@suse.de> Content-Language: fr From: Simon Marchi In-Reply-To: <20260322065808.1127765-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/22/26 2:58 AM, Tom de Vries wrote: > We generally avoid C++ streams in GDB sources [1]. > > Remove an instance of std::ostringstream in arc_check_tdesc_feature. > > While we're at it, fix an array index bug: > ... > - reg_names << " or '" << reg.names[0] << "'"; > + string_appendf (reg_names, " or '%s'", reg.names[i]); > ... > > Tested on x86_64-linux, using a trigger patch: > ... > - if (!found && reg.required_p) > + if (true || (!found && reg.required_p)) > ... > and doing "maint selftest" and observing the output: > ... > Running selftest unpack_field_as_long::ARC600. > Error: Cannot find required register(s) 'r0' in feature 'org.gnu.gdb.arc.core'. > Error: Cannot find required register(s) 'pc' in feature 'org.gnu.gdb.arc.aux'. > ... > > [1] https://sourceware.org/pipermail/gdb-patches/2026-March/226117.html > --- > gdb/arc-tdep.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/gdb/arc-tdep.c b/gdb/arc-tdep.c > index ff283014e52..4936a5c8fbb 100644 > --- a/gdb/arc-tdep.c > +++ b/gdb/arc-tdep.c > @@ -44,7 +44,6 @@ > > /* Standard headers. */ > #include > -#include > > /* The frame unwind cache for ARC. */ > > @@ -2100,16 +2099,16 @@ arc_check_tdesc_feature (struct tdesc_arch_data *tdesc_data, > > if (!found && reg.required_p) > { > - std::ostringstream reg_names; > + std::string reg_names; > for (std::size_t i = 0; i < reg.names.size(); ++i) > { > if (i == 0) > - reg_names << "'" << reg.names[0] << "'"; > + string_appendf (reg_names, "'%s'", reg.names[0]); > else > - reg_names << " or '" << reg.names[0] << "'"; > + string_appendf (reg_names, " or '%s'", reg.names[i]); Looks like you fixed a bug here (0 -> i). Approved-By: Simon Marchi Simon