On 5.1.2017 15:31, Yao Qi wrote:
> On 17-01-04 18:42:27, Ivo Raisr wrote:
>> On 12.12.2016 13:53, Yao Qi wrote:
>>
>>> Hi Ivo,
>>> Your patch does two orthogonal things IMO,
>>>
>>>   - Pseudo register support enhancement, patch #1
>>>   - XML target description support and sparc*-tdep.c updates, patch #2,
>>>
>>> Can you split them to two patches?
>> Hi Yao,
>>
>> Thank you for looking into my changes.
>> I think I can see your motivation behind splitting the patch into two,
>> for better readability and manageability.
>> However my intention was only to provide support for registers
>> supplied by target description (Valgrind shadow registers in addition
>> to sparc real hardware ones).
>> Pseudo register changes were just a necessity to get this done
>> because Valgrind shadow registers are considered as "real" registers
>> and thus they are numbered before any pseudo registers.
>> This also means I cannot draw a clear line between your suggested
>> patch #1 and #2. Can you take my whole patch as is?
>>
> The line is clear to me.  I split your patch, and show the patch #1 here.
> Does it work for you?  Note you still need to add comments to new functions
> in the patch below.

I think I see the line now as well. Please find patch #1 together with a 
ChangeLog entry.
The patch was successfully built and tested on Solaris sparc.
After you find it ok, I will prepare patch #2.
I.