From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SYpMHN3bDWpPewoAWB0awg (envelope-from ) for ; Wed, 20 May 2026 12:05:49 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=gWv9mdv4; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=gWv9mdv4; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5FBA81E024; Wed, 20 May 2026 12:05:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3AB681E024 for ; Wed, 20 May 2026 12:05:48 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AF7404BB58E7 for ; Wed, 20 May 2026 16:05:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AF7404BB58E7 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=gWv9mdv4; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=gWv9mdv4 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazlp170130007.outbound.protection.outlook.com [IPv6:2a01:111:f403:c20f::7]) by sourceware.org (Postfix) with ESMTPS id 986EA4BAE7E9 for ; Wed, 20 May 2026 16:05:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 986EA4BAE7E9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 986EA4BAE7E9 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c20f::7 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1779293119; cv=pass; b=MSPpLzOEeqansOA17qKbDBq+df7FaNzKwMy1EvMqjnTFvQ5aKmlqgrsSvf6Gw6cFtbqzQDI4TO9RBtQRhWMNj1YIplRkX6F1VcVpp797Lt9QPxkbnFekeOQA8BvfzpA/m35kspUHznvnd/TuqiBhvZ9HqlPhHOD2ZF/cWm0q6Tk= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1779293119; c=relaxed/simple; bh=qoNoyXTEY0e7W6xRWg6QYfbh7ZP7AdX2Y9/MTyYtrMY=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=irGcCcnCSv3Efhclu7eMESFuu8XAaoJsxd0GaMciz3OgqKX86NjO6mZyCaol9pwQk3N98+NbOa3Gqq0oNDK121AHIWjd6FKS1RF48b06+QDtKL6FVBQrx6ictoip0C40iJYpDE5m/PCfdXmDCkM6xXBYDXH1h2juCbuVnYAeKgQ= ARC-Authentication-Results: i=3; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=gWv9mdv4; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=gWv9mdv4 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 986EA4BAE7E9 ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=WKU5q+k2G2GT2f6zpd6hdrFbQpuucHveVlxNJPqNn9Acag3FogT7vQhEXKr67X+OP3/Rr4kABPpg4tZ03u2C33CCajWNzCgPlUCAhoD7iVjf+wZADOFt84IdpTFOhrEh8GbseeBikbRbY9+PKLQcZrn9+mso3mtALGSkNp++6sUSDviqBesFeAaaC79tUrdQVlaUbH3ldsSP72aZ8NyfWmmBfwe5z11JbQd0I8xEIP+M5/H/xwNyfTwH0peVjd8AT7K9D3UN8djjjptTdT9v1fkm4fwUy6c5g/U4T73NQy33TPdA1jh990zODtW0PfV0rcGpRnnpVlhM8wdGYKN2iw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ruuLjhNpKr0H+V1eCssB0jbkCEbhsydU5BsPjm0h03M=; b=uMSlQAmNbZ+bqL/S24sN1x0P+UMhRUCPtAkoYw4E3TDdN0/PPZfRLTJes7y+lOO7FLe0HImVzKzf6R285ohq8SVQxMBRjUbw9X896C8U0onfoed0NeAsDuTOvf9B1X/8Y8W0OUXjJGuePCkDTzZng42RlRps2VdqE8Sn0GCdVWFOekphlXij+v7C403FKkImtVKidypORUVMEsxsyR4T8DTm3QVSrwH82HYaSxyKy8EhfKFupUJzNbU2vbPAgumNOwk72568wqoZCxhA+anI+AH/PUZzWTa8QB2jeptB4h/EMx1rWccFhD6bEh68zJ+ybuRHT2qHXn3dpJraF9G4tw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=tromey.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ruuLjhNpKr0H+V1eCssB0jbkCEbhsydU5BsPjm0h03M=; b=gWv9mdv4heX8CDZkbBM9BEXfKWIsmPF+G/IuWhIIBel6SflbasMicb2GAcSstSuFEi6FM/TMTDod6QWw33DQO8UInDOuz7yZ98dmuOhGMYEbBvUsdcO/jBoESydo5rC0wV5Nt3i6rVYlasMPDEWEJ7EX4MzI4g1Wzjsz/eNt3mU= Received: from DUZPR01CA0099.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bb::24) by DU5PR08MB10823.eurprd08.prod.outlook.com (2603:10a6:10:528::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.19; Wed, 20 May 2026 16:05:14 +0000 Received: from DB1PEPF000509E4.eurprd03.prod.outlook.com (2603:10a6:10:4bb:cafe::3d) by DUZPR01CA0099.outlook.office365.com (2603:10a6:10:4bb::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.48.16 via Frontend Transport; Wed, 20 May 2026 16:05:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by DB1PEPF000509E4.mail.protection.outlook.com (10.167.242.54) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.25.13 via Frontend Transport; Wed, 20 May 2026 16:05:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OySfTWYdOPHSbow0FzOhwCViRClpn2eZ7YXpwy0ebH20ITTEt8k/bLEyTTZRMGvqkxvJKS7jszeRXupIsgysW8Qza6Y9T7U5E3u2fZgY/bX3Ky6DXjIO0gaBuIb8kEwn3gQ1S58+vuTilTbbG9F46Cku5gktj63PLTMd7iA6ejZ8gQuwL8ehWkH476YUfAmNDhpGpOqL0W5my4EPSk45QUzHm91mCiD/hOInZkNPdWOoCmiCHl3n17f9svY2KoviE8UEhWVK4MSHqPW1P/UtNgHWzUeMo879ZsgydpJJkA0seXm3/64lPsAT/pLLHVpan8XukrfILboJzjgs7YrqQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ruuLjhNpKr0H+V1eCssB0jbkCEbhsydU5BsPjm0h03M=; b=i9qpwIAh9fVmajEXU3oq/lAH9rhIWz0pQuVuDldo5DWXB4cmwHuKh4pkFKWHasxYyHgU/qTOn54aNBiBxQ2u6Xe8MW5jEXPu1yAQbBie7sIOrPlbmKg9itGYgRfudJ+UDAi5vQN77gkGRRqsOOb6bXe8iJUyDR/ALu+BUki7YFCBM/h5DV0a6VAiX40aZXlPTDDYOLX3uNzjpgepU0jrNUvVN9/6cPG63gD8upkA2khotth97cfjEDKfpyvZKZnc8TYdBwz/Ey7FI42HAzQczMQquz/zg42fB6UAi4h6HOiVVfTwh2vq5gyI+TPLEBC2X3h861dqHz2Pql8GTIs+JQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ruuLjhNpKr0H+V1eCssB0jbkCEbhsydU5BsPjm0h03M=; b=gWv9mdv4heX8CDZkbBM9BEXfKWIsmPF+G/IuWhIIBel6SflbasMicb2GAcSstSuFEi6FM/TMTDod6QWw33DQO8UInDOuz7yZ98dmuOhGMYEbBvUsdcO/jBoESydo5rC0wV5Nt3i6rVYlasMPDEWEJ7EX4MzI4g1Wzjsz/eNt3mU= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DU0PR08MB8663.eurprd08.prod.outlook.com (2603:10a6:10:401::6) by AS8PR08MB6630.eurprd08.prod.outlook.com (2603:10a6:20b:337::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.48.14; Wed, 20 May 2026 16:04:10 +0000 Received: from DU0PR08MB8663.eurprd08.prod.outlook.com ([fe80::f957:cec9:ec8d:7968]) by DU0PR08MB8663.eurprd08.prod.outlook.com ([fe80::f957:cec9:ec8d:7968%2]) with mapi id 15.21.0025.023; Wed, 20 May 2026 16:04:10 +0000 Message-ID: Date: Wed, 20 May 2026 17:04:09 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] gdb/python: add gdbpy_borrowed_ref To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260428162416.511367-1-matthieu.longo@arm.com> <20260428162416.511367-2-matthieu.longo@arm.com> <878q9kipc2.fsf@tromey.com> <87h5o3b3ru.fsf@tromey.com> Content-Language: en-US From: Matthieu Longo In-Reply-To: <87h5o3b3ru.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PA7P264CA0369.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:37c::8) To DU0PR08MB8663.eurprd08.prod.outlook.com (2603:10a6:10:401::6) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DU0PR08MB8663:EE_|AS8PR08MB6630:EE_|DB1PEPF000509E4:EE_|DU5PR08MB10823:EE_ X-MS-Office365-Filtering-Correlation-Id: 7eb941f1-d471-4ea8-d309-08deb68993ad x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|1800799024|376014|366016|6133799003|56012099003|18002099003|22082099003|4143699003|11063799006; X-Microsoft-Antispam-Message-Info-Original: CBX0fMCAZmgtDb3AcDLMsoj7MoG5G1zc0YcgbZ0X1oYy2WJag/4MpNiU6DRK63NLXYtTNFytFb/we6MEsx+vg6JXK0SAj1cZAtxSi0RyWPBAsnGGbT1fmdx/68zi8KpZUGG5gy5E83PnPv5/ofPif97aNqs9f+nmUD7pD20B493/yjI3ii5EC4+a/GUglzQzUDojGk52BzWlNIwkl4NFDD8v+p8Z74WhSduyaQ9WTFCzeWCBcQKh78oSQuVV39vdwp+8vEM2NxhQYnJRFUvjul3OWBOGeWPLc3aJMp7AR9nHiNuK9yGKaHngjfTWoDMrejFE1qGPayQ63uB3q+vsILKYPY+hBptCSC/2gK4cHkcpeSUdPp/hKW22dHMf7qzEsDM/6IITAtHjJeM6AHIrTEOsjuKB9YDPoCetAGOCFZ4ixRrMeZOODh5waEnWtm9gf3jdSaZIGkANmDG9iUVlObtntKo0or7EBZoy6avWtkLYC/kfcIOAMIbiWwSVAeXw9VxL8pUoJDB7eTuODBFBg8BkgEnr0VTrNf7g1bKd/YPefS0tqiuvosm0RwF/AsJKgKR0pn5S+3e78QI2c9Iji5sPYD2oR7IEcdbx1zHGcgtx/i/gKI/VEnxWh8/a6X7XEZjGVp/2UWLkxWYDCPgxPUJKRy6mo9MxZe3XqxyGH1qaEKj5PymUYtFOfZ76VxHw X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR08MB8663.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(6133799003)(56012099003)(18002099003)(22082099003)(4143699003)(11063799006); DIR:OUT; SFP:1101; X-Exchange-RoutingPolicyChecked: aL/Vrz9HShNK9gNS32rZ6tPzy2BlKWReAHw4iFpb3+Q30ZozGOvdz6TxHgijoZyxa+k3IFQEMkbuV5cTGLuoicoelV76T2CWk5qg+hHCXuIM8ynzoppW4h0Pgvp3xE5j7zm9P+gBJGWFVMM2+q7DepKxrxFYRSA4pnUMwp+ltMtaq0q1VJXDrxWSm+4xUlysgMDkUzl68PJo5dI7XASub+UzN17mZ/Uicm+Rm8WyqLvYBTsbiJ6RC3QhQIvRANfYdtifwNR4eo1cuo7Gfg5SE/rFgHFcLLlAtUmJQdmCmEu5zkVavT3dYHcOVjTYRyoaiR6ylNQyqcYPMnrJTmqQKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6630 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB1PEPF000509E4.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 340549dc-4f03-41c9-22ae-08deb6896db0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|14060799003|82310400026|36860700016|1800799024|35042699022|4143699003|18002099003|56012099003|22082099003|11063799006|6133799003; X-Microsoft-Antispam-Message-Info: 5QqhDspgkXshz/S63yiv6l/676DgDt71JiiW975XYk7k3EJ9kgK/3IgNz8SxfHXOLPf68mYNvam0wQ3BzIn4kTSvqOX2eCh8KtibfRsTX+ovqBamzYZAhXOrKhJmVPswJuM7j5ReC1ubXYdVYiMjlkHlOyVTfwdCYjaoeAZ+thEypuVM/2MkdtnVcWRPs8VerWeOiKdrJoNiIYGzPEDy69Z69aWDlio3J4x9MD6g4nRxYqV5OK3bFI6BQ1GtMieRVGQguO75HRuAAaMxhGFXsf9VPo7Lr+S7b1bWuufMlRcLXBYGsrnyQDpG2WeAOEtM+29+jiaTEZpUZjg9cMq/Vkx427h07LIq8zHGT/GA78RnM4c5D4LwPHfe28FSYMhJndTF+wF0hrTOg/+HtdXbglQAoi9SCitMhKu47ngCiY6r63R7PIH46BYU+YqKWRqqzKXHr2nHMMLLeqlqw5IaEEwSMle2ZKe70LdfenCu9ySB/5r4zQVsUV+YrS1rJEhJLv1FUAz/S6CSxGk8gLnSgM9ZLenuNRNNuhvZ8AT71EIxhVKyPkhPHB+BSBASGo3ja2hlpOtWi4iZTZZUy6t7V53oeqSAwnMopecQSh19WOHdXvKiYs6LV69bQ9jYn6iW0XRAk7mWt7AmFvuADSGMyUFmRdgEya8I/Ig08Z74JhM6YQXYK/raLmohzcBxKTrgvyzZ+lJJ+9c/wcvS6JcToLkMltcsQjtek/vjce12b3M= X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(14060799003)(82310400026)(36860700016)(1800799024)(35042699022)(4143699003)(18002099003)(56012099003)(22082099003)(11063799006)(6133799003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: abNxkWH12xRVMI4TFaX8y4uLRZl20Dx25LU5ux3o2Ej5tq6NeVhVQooX+tnzFQRms41PcNav4AJg9MkRodmcN35nyrdFFx6qOr33EUr63IJRPdChR+QAZAYNCDg5Z0X9lo97HXLL5CoRcgPm5EFGVCQpjvCOi1hF6O4RjAmF3gQjO1Vf5pNGR7e9rMpzS1c1qnbV9tHBLboBlyhYJSB3L508P6PIy9ry2hgRsVggcktqRIXS0Ae0ECOjdmtudBGYXqqXEoxYG8UCnONmnmvxPA4rNsxmr7fVFns2YFg8qt18nBtXGI4ijIH09un9lIAc9Jyw47WwfLRR2g+JSEjhEi94MyaBkmr57wNEzXDRJN6Rax+T67MDwnbPsonJ/D1bkeUhgcM51tyB+qn/mHSOmvuIP83hQ8ChQ4X3Zl/nPhC42cEPENdSYIHg2eZFHy0P X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2026 16:05:13.7100 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7eb941f1-d471-4ea8-d309-08deb68993ad X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509E4.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU5PR08MB10823 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 19/05/2026 20:25, Tom Tromey wrote: >>>>>> "Matthieu" == Matthieu Longo writes: > >>> So on the whole I'd prefer to drop this from this series. That way it >>> won't conflict or cause problems with the stuff I'm planning to send. > > Matthieu> A lot of upcoming patches are using gdbpy_borrowed_ref<> because it > Matthieu> simplified a lot the code in some places. > Matthieu> Dropping it is going to make things definitely more difficult on my side. > > Ok, no problem. > > I'll update the safety series to use templates. > > Tom Just to be sure, should I take your last sentence as an approval of the patch ? Matthieu