Re: [PATCH 07/23] Delete unnecessary code from kill_command

Aktemur, Tankut Baris
2019-10-01T10:19:25Z

Hi,

* On September 7, 2019 1:28 AM, Pedro Alves wrote:
>
> diff --git a/gdb/infcmd.c b/gdb/infcmd.c
> index d7a7e6f933..a12dba23aa 100644
> --- a/gdb/infcmd.c
> +++ b/gdb/infcmd.c
> @@ -2503,20 +2503,6 @@ kill_command (const char *arg, int from_tty)
> printf_unfiltered (_("[Inferior %d (%s) killed]\n"),
> infnum, pid_str.c_str ());
>
> - /* If we still have other inferiors to debug, then don't mess with
> - with their threads. */
> - if (!have_inferiors ())
> - {
> - init_thread_list (); /* Destroy thread info. */

Removing 'init_thread_list' skips re-initialization of the
'highest_thread_num' global back to zero. In turn, this causes the
following failure:

FAIL: gdb.arch/i386-mpx-simple_segv.exp: print nopass stop: display

because the output becomes

Thread 1 "i386-mpx-simple" received signal SIGSEGV

instead of

Program received signal SIGSEGV

Regards,
-Baris

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928